chore: add BF deal #805
Merged
chore: add BF deal #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
9 tasks
HardeepAsrani
requested changes
Oct 18, 2023
There was a problem hiding this comment.
One more issue, I found is that the notices appear even if you've Pro version installed. As mentioned in the issue, the notice shouldn't be visible if the user has Pro version.
And the Banner on other pages don't appear if you dismiss the global notice. Was this how Harshit requested or was a mistake?
|
@Soare-Robert-Daniel I can not see the LTD banner on the |
HardeepAsrani
requested changes
Oct 19, 2023
HardeepAsrani
approved these changes
Oct 19, 2023
|
Fixes in #815 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Black Friday deal.
Screen Shots
Testing
The giant banners will have a dynamic text that shows the remaining time in the top-left corner. The start is set early to facilitate the test (it will be changed after the approval).
The time interval set for testing is 2023-10-10 00:00:00 and 2023-11-27 23:59:00.If possible, try to change the server time to see if the banner is working correctly when the time is over.The PRs are: