Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: prepare BF event #1922

Merged
merged 14 commits into from
Oct 23, 2023
Merged

chore: prepare BF event #1922

merged 14 commits into from
Oct 23, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Oct 16, 2023 •
edited
Loading

Closes #.

Summary

Add functions for sales events like Black Friday.

Screenshots

image

image

Test instructions

  1. Check if the banners appear with the correct link/URL. More about this here: https://github.com/Codeinwp/themeisle/issues/1575#issuecomment-1757321452
  2. By using all three plugins (Neve, Otter, Feedzy), check the admin notice (the small one) priority. There should be notice only for the highest priority product. The order is Neve > Otter > Feedzy. More on this here: https://github.com/Codeinwp/themeisle/issues/1575#issuecomment-1761388729

The giant banners will have a dynamic text that shows the remaining time in the top-left corner. The start is set early to facilitate the test (it will be changed after the approval). The time interval set for testing is 2023-10-10 00:00:00 and 2023-11-27 23:59:00. If possible, try to change the server time to see if the banner is working correctly when the time is over.

The PRs are:

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Oct 17, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Oct 17, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review October 17, 2023 08:52
@pirate-bot
Copy link
Contributor

pirate-bot commented Oct 17, 2023 •
edited
Loading

Bundle Size Diff

Package Old Size New Size Diff
Animations 275.01 KB 275.01 KB 0 B (0.00%)
Blocks 1.47 MB 1.47 MB 0 B (0.00%)
CSS 89.3 KB 89.3 KB 0 B (0.00%)
Dashboard 131.28 KB 132.27 KB 1021 B (0.76%)
Export Import 87.21 KB 87.21 KB 0 B (0.00%)
Pro 346.54 KB 346.54 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Oct 17, 2023 •
edited
Loading

Plugin build for 95cfe3f is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Oct 17, 2023 •
edited
Loading

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 89.52 17.01 88.69 0 (60ms) 36.84 (80ms)
Values above 60ms "0 - 86.14, 1 - 95.31, 2 - 92.51, 3 - 69.29, 4 - 77.03, 5 - 64.35, 6 - 122.02, 7 - 117.06, 8 - 101.81, 9 - 77.52, 10 - 113.35, 11 - 70.36, 12 - 71.97, 13 - 90.78, 14 - 70.30, 15 - 96.74, 16 - 110.63, 17 - 88.69, 18 - 85.03"

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Oct 17, 2023
HardeepAsrani
HardeepAsrani approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment but it looks good. We can get all of them in QA together to confirm they also work fine together. And we can also make the product specific changes to define priority properly.

This was referenced Oct 18, 2023
Merged
Merged
@HardeepAsrani
Copy link
Member

Also as talked on Slack, we can show the notice on all screens on Otter's main dashboard.

@HardeepAsrani HardeepAsrani self-requested a review October 18, 2023 19:11
HardeepAsrani
HardeepAsrani approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@HardeepAsrani HardeepAsrani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more issue, I found is that the notices appear even if you've Pro version installed. As mentioned in the issue, the notice shouldn't be visible if the user has Pro version.

Sorry, hit approved by mistake.

HardeepAsrani
HardeepAsrani requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more issue, I found is that the notices appear even if you've Pro version installed. As mentioned in the issue, the notice shouldn't be visible if the user has Pro version.

@harshitarora-in
Copy link
Contributor

@Soare-Robert-Daniel Small fix is needed in the LTD banner link, it should be: https://themeisle.com/plugins/otter-blocks/blackfriday?utm_source=wpadmin&utm_medium=dashboard&utm_campaign=blackfridayltd23&utm_content=otter-blocksblackfriday

In the current version, you have used utm_medium=globalnotice but it should be utm_medium=dashboard

@harshitarora-in
Copy link
Contributor

@Soare-Robert-Daniel @HardeepAsrani If I dismissed the Neve LTD notice when will the Otter Blocks dismissible notice get triggered?

@HardeepAsrani
Copy link
Member

@harshitarora-in Do we want to display notices back to back? We've avoided showing notices to users once they dismiss one. Based on past experience, users don't seem very happy if we show them too many notices within a small amount of time. Let me know what you think.

@harshitarora-in
Copy link
Contributor

@HardeepAsrani Yes Yes, I agree. I'm just asking about the current delay between two dismissible notices.

@HardeepAsrani
Copy link
Member

@harshitarora-in Right now we don't display another Global notice if one has been dismissed.

@harshitarora-in
Copy link
Contributor

@harshitarora-in Right now we don't display another Global notice if one has been dismissed.

Got it, thanks for the clarification.

HardeepAsrani
HardeepAsrani requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Soare-Robert-Daniel The banner still appears when you have Otter Pro.

Screenshot 2023-10-19 at 6 13 27 PM

@Soare-Robert-Daniel
Copy link
Contributor Author

As a side note here for future things, the pro verification must made at least in init hook. The direct verification works only on dev local mode since all otter files are loaded all at once.

@rodica-andronache
Copy link

@Soare-Robert-Daniel all good now, thank you!

@HardeepAsrani HardeepAsrani merged commit 21eeb8e into development Oct 23, 2023
@HardeepAsrani HardeepAsrani deleted the feat/limited-offers branch October 23, 2023 12:32
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HardeepAsrani HardeepAsrani HardeepAsrani approved these changes

Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Soare-Robert-Daniel @pirate-bot @HardeepAsrani @harshitarora-in @rodica-andronache