-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BF deal #4121
Add BF deal #4121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more issue, I found is that the notices appear even if you've Pro version installed. As mentioned in the issue, the notice shouldn't be visible if the user has Pro version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one seems to work properly.
@Soare-Robert-Daniel please update the customizer link to -> https://themeisle.com/themes/neve/upgrade/?utm_source=wpadmin&utm_medium=customizer&utm_campaign=blackfriday23 |
@harshitarora-in, all done 🔧 . Please update this comment so the QA team knows about the change 🙏 |
@Soare-Robert-Daniel Done, Thanks! |
@Soare-Robert-Daniel if I have both Neve and Feedzy installed, now the WP Dashboard notice shows the Feedzy one instead of Neve https://vertis.d.pr/i/TPCp8V |
This is a Feedzy issue. I send the fix 🔧 |
@Soare-Robert-Daniel all good now, thank you! |
🎉 This PR is included in version 3.7.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Add Black Friday event.
Will affect visual aspect of the product
YES
Screenshots
Test instructions
The big banners will have a dynamic text that shows the remaining time in the top-left corner. For the start is set to an early one to facilitate the test (it will be changed after the approval).
The time interval set for testing is: 2023-10-10 00:00:00 and 2023-11-27 23:59:00. If possible, try to change the server time to see if the banner is working correctly when the time is over.The PRs are:
Check before Pull Request is ready:
Closes #.