Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BF deal #4121

Merged
merged 12 commits into from
Oct 23, 2023
Merged

Add BF deal #4121

merged 12 commits into from
Oct 23, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Oct 17, 2023

Summary

Add Black Friday event.

Will affect visual aspect of the product

YES

Screenshots

image

image

image

Test instructions

  1. Check if the banners appear with the correct link/URL. More about this here: https://github.com/Codeinwp/themeisle/issues/1575#issuecomment-1757321452
  2. By using all three plugins (Neve, Otter, Feedzy), check the admin notice (the small one) priority. There should be notice only for the highest priority product. The order is Neve > Otter > Feedzy. More on this here: https://github.com/Codeinwp/themeisle/issues/1575#issuecomment-1761388729

The big banners will have a dynamic text that shows the remaining time in the top-left corner. For the start is set to an early one to facilitate the test (it will be changed after the approval). The time interval set for testing is: 2023-10-10 00:00:00 and 2023-11-27 23:59:00. If possible, try to change the server time to see if the banner is working correctly when the time is over.

The PRs are:

Check before Pull Request is ready:

Closes #.

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Oct 17, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Oct 18, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review October 18, 2023 08:02
@pirate-bot
Copy link
Collaborator

pirate-bot commented Oct 18, 2023

Plugin build for cdcae52 is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Oct 18, 2023
Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more issue, I found is that the notices appear even if you've Pro version installed. As mentioned in the issue, the notice shouldn't be visible if the user has Pro version.

Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seems to work properly.

inc/core/limited_offers.php Outdated Show resolved Hide resolved
@harshitarora-in
Copy link
Contributor

@Soare-Robert-Daniel
Copy link
Contributor Author

@harshitarora-in, all done 🔧 . Please update this comment so the QA team knows about the change 🙏

@harshitarora-in
Copy link
Contributor

@harshitarora-in, all done 🔧 . Please update this comment so the QA team knows about the change 🙏

@Soare-Robert-Daniel Done, Thanks!

@rodica-andronache
Copy link
Contributor

@Soare-Robert-Daniel if I have both Neve and Feedzy installed, now the WP Dashboard notice shows the Feedzy one instead of Neve https://vertis.d.pr/i/TPCp8V

@Soare-Robert-Daniel
Copy link
Contributor Author

@Soare-Robert-Daniel if I have both Neve and Feedzy installed, now the WP Dashboard notice shows the Feedzy one instead of Neve https://vertis.d.pr/i/TPCp8V

This is a Feedzy issue. I send the fix 🔧

@rodica-andronache
Copy link
Contributor

@Soare-Robert-Daniel all good now, thank you!

@cristian-ungureanu cristian-ungureanu merged commit ca8f87a into development Oct 23, 2023
@cristian-ungureanu cristian-ungureanu deleted the feat/limited-offers branch October 23, 2023 13:29
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.7.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants