-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add permits for index entries #454
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekSuchanek
force-pushed
the
feature/index-filtering
branch
from
September 5, 2023 13:34
d8a86fe
to
79892e1
Compare
MarekSuchanek
force-pushed
the
feature/index-filtering
branch
from
September 6, 2023 07:00
79892e1
to
5cbcc61
Compare
kburger
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor question inline
src/main/java/nl/dtls/fairdatapoint/entity/index/settings/IndexSettings.java
Outdated
Show resolved
Hide resolved
MarekSuchanek
force-pushed
the
feature/index-filtering
branch
11 times, most recently
from
September 15, 2023 11:51
63b43da
to
e740014
Compare
MarekSuchanek
force-pushed
the
feature/index-filtering
branch
2 times, most recently
from
September 15, 2023 13:40
ec09d57
to
69d44dd
Compare
src/main/java/nl/dtls/fairdatapoint/api/controller/index/IndexAdminController.java
Fixed
Show fixed
Hide fixed
MarekSuchanek
force-pushed
the
feature/index-filtering
branch
from
September 15, 2023 14:18
69d44dd
to
97ff0cf
Compare
MarekSuchanek
force-pushed
the
feature/index-filtering
branch
from
October 3, 2023 06:00
97ff0cf
to
f169fff
Compare
MarekSuchanek
force-pushed
the
feature/index-filtering
branch
from
October 3, 2023 06:11
f169fff
to
a8c86ea
Compare
@kburger I added the configuration default value for auto-permit and also actions on permit change (deleting harvested data and triggering retrieval if accepted). Could you please check one more time so we can merge this? |
kburger
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.