Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spack-stack-dev from spack develop as of 2024/10/31 #1363

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Nov 4, 2024

Summary

  • Update submodule pointer for spack for the changes in Update spack-stack-dev from spack develop as of 2024/10/31 spack#482 (update from spack develop as of 2024/10/31)
  • Make macOS CI test look like the UBuntu CI tests (split into two steps: first create buildcache environment, then install test environment from the buildcache)
  • Remove deprecated -a flag from spack buildcache push for all GitHub actions workflows
  • Add +classic-names to the intel-oneapi-mpi external package definition in GitHub actions. May need to do the same for each of the preconfigured sites when using icc+icpc+ifort. Without +classic-names, it works for icx+icpx+ifort and for ``icx+icpx`+`ifx`.
  • Updates to configs/common/packages.yaml to remove deprecated variants and pin certain packages to avoid duplicate packages 
  • Update tier2 site config for blackpeark and bump PrgEnv for Narwhal
  • Bug fix: gsi-env does not depend on esmf, for some reason the concretizer didn't realize this until now

Testing

Describe the testing done for this PR.

Applications affected

Potentially all

Systems affected

None directly

Dependencies

Issue(s) addressed

Resolves #1181

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji self-assigned this Nov 4, 2024
Copy link
Collaborator

@srherbener srherbener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for all the work to get our spack fork sync'd up!

@AlexanderRichert-NOAA
Copy link
Collaborator

This looks really good. The only issue I encountered in testing is that I'll need to pin the GDAL version in the NCO template. Is it alright if I add this here, or would you prefer it in a followup PR?

@climbfuji
Copy link
Collaborator Author

This looks really good. The only issue I encountered in testing is that I'll need to pin the GDAL version in the NCO template. Is it alright if I add this here, or would you prefer it in a followup PR?

Thanks for testing! Feel free to push to this PR.

@climbfuji
Copy link
Collaborator Author

@AlexanderRichert-NOAA I'll merge the spack PR for the update from spack dev and update the submodule pointer here, but will wait for your gdal nco update before merging this.

@AlexanderRichert-NOAA
Copy link
Collaborator

Done, thanks

@climbfuji climbfuji merged commit 9fbd7bb into JCSDA:develop Nov 14, 2024
8 checks passed
@climbfuji climbfuji deleted the feature/update_from_spack_dev_20241031 branch November 14, 2024 11:46
climbfuji added a commit that referenced this pull request Nov 15, 2024
…ntainer builds for gcc and clang, and work towards fixing intel (#1381)

This PR is a follow up to the update from spack develop in #1363. It removes the external gmake packages so that the new requirement for gmake to be one of 4.2.1 or 4.4.1 can be honored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Update spack to v0.22.1 (or a newer release or develop, September 2024)
3 participants