Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MiqFileStorage into core and provider specific gems #403

Closed
3 tasks
NickLaMuro opened this issue Nov 6, 2018 · 9 comments
Closed
3 tasks

Move MiqFileStorage into core and provider specific gems #403

NickLaMuro opened this issue Nov 6, 2018 · 9 comments
Assignees

Comments

@NickLaMuro
Copy link
Member

NickLaMuro commented Nov 6, 2018

Related to the large issue, #231 (the mount/* checkbox), though has grown in scope since that issue was created do to the addition of the following classes/libs being created/reworked:

  • lib/gems/pending/util/miq_file_storage.rb
  • lib/gems/pending/util/miq_object_storage.rb
  • lib/gems/pending/util/miq_ftp_lib.rb
  • lib/gems/pending/util/object_storage/*.rb
    • miq_ftp_storage.rb
    • miq_s3_storage.rb
    • miq_swift_storage.rb

Really, this is all manageiq related, and should just live there in lib/ (or a core gem... if we ever go that route). The provider specific ones should live in their respective provider repos, and get loaded in as part of the rake tasks to determine what functionality is available then (instead of the hard coding that is done currently).

Task items

@NickLaMuro
Copy link
Member Author

cc @Fryguy @carbonin

@miq-bot
Copy link
Member

miq-bot commented May 6, 2019

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@NickLaMuro
Copy link
Member Author

NickLaMuro commented Nov 23, 2019

Updated full file list of files to be extracted (see PR description for previous version):

  • lib/gems/pending/util/miq_file_storage.rb
  • lib/gems/pending/util/miq_ftp_lib.rb
  • lib/gems/pending/util/miq_object_storage.rb
  • lib/gems/pending/util/mount/*.rb
    • lib/gems/pending/util/mount/miq_generic_mount_session.rb
    • lib/gems/pending/util/mount/miq_glusterfs_session.rb
    • lib/gems/pending/util/mount/miq_local_mount_session.rb
    • lib/gems/pending/util/mount/miq_nfs_session.rb
    • lib/gems/pending/util/mount/miq_smb_session.rb
  • lib/gems/pending/util/object_storage/*.rb
    • lib/gems/pending/util/object_storage/miq_ftp_storage.rb
    • lib/gems/pending/util/object_storage/miq_s3_storage.rb
    • lib/gems/pending/util/object_storage/miq_swift_storage.rb
  • spec/util/miq_file_storage_spec.rb
  • spec/util/miq_ftp_lib_spec.rb
  • spec/util/miq_object_storage_spec.rb
  • spec/util/mount/miq_generic_mount_session_spec.rb
  • spec/util/mount/miq_local_mount_session_spec.rb
  • spec/util/object_storage/miq_ftp_storage_spec.rb
  • spec/util/object_storage/miq_s3_storage_spec.rb
  • spec/util/object_storage/miq_swift_storage_spec.rb
  • spec/support/custom_matchers/exist_on_ftp_server.rb
  • spec/support/custom_matchers/have_size_on_ftp_server_of.rb
  • spec/support/contexts/generated_tmp_files.rb
  • spec/support/contexts/with_ftp_server.rb

@miq-bot
Copy link
Member

miq-bot commented Jun 11, 2020

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.

@miq-bot miq-bot added the stale label Jun 11, 2020
@gtanzillo gtanzillo removed the stale label Jun 29, 2020
@NickLaMuro
Copy link
Member Author

Note: This will most likely just be removed/deleted, as we are moving away from supporting the process of connecting to file storage providers, and leaving that up to the user to mount it themselves.

@Fryguy
Copy link
Member

Fryguy commented Apr 9, 2021

Did you want to keep this issue open anyway, or should we just close?

@NickLaMuro
Copy link
Member Author

@Fryguy I think I am going to leave it open until we delete it, and then close it. But if you think I might forget (which... honestly, I might), we can also close it now. I just wanted something open as a reminder that it needed to be updated.

@miq-bot miq-bot added the stale label Feb 27, 2023
@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2023

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot
Copy link
Member

miq-bot commented May 29, 2023

This issue has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this issue if this issue is still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot miq-bot closed this as completed May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants