Move meminfo-writer to /usr/bin #123
Conversation
There it a tendency to merge /usr/bin and /usr/sbin (replace the latter with a symlink). This caused a few issues already, including SELinux mislabeling (QubesOS/qubes-issues#9663), file install issues where %_sbindir RPM macro points at /usr/bin, and now on in-place upgrade systemd unit points at /usr/sbin/meminfo-writer that doesn't exist at the upgrade time. Since this merging happened on Fedora 42 now, and much earlier on Archlinux too, simplify things by simply moving meminfo-writer to /usr/bin and don't have any special cases for distributions with merged /usr/sbin or not. The change isn't relevant for Debian (yet?) but also shouldn't hurt either. QubesOS/qubes-issues#9807
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
=======================================
Coverage 60.56% 60.56%
=======================================
Files 6 6
Lines 951 951
Branches 104 104
=======================================
Hits 576 576
Misses 285 285
Partials 90 90 ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025030303-4.3-fedora&flavor=templates Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update
Failed tests10 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/129058#dependencies 6 fixed
Unstable testsPerformance TestsPerformance degradation:No issues Remaining performance tests:No remaining performance tests |
There it a tendency to merge /usr/bin and /usr/sbin (replace the latter
with a symlink). This caused a few issues already, including SELinux
mislabeling (QubesOS/qubes-issues#9663), file install issues where
%_sbindir RPM macro points at /usr/bin, and now on in-place upgrade
systemd unit points at /usr/sbin/meminfo-writer that doesn't exist at
the upgrade time.
Since this merging happened on Fedora 42 now, and much earlier on
Archlinux too, simplify things by simply moving meminfo-writer to
/usr/bin and don't have any special cases for distributions with merged
/usr/sbin or not. The change isn't relevant for Debian (yet?) but also
shouldn't hurt either.
QubesOS/qubes-issues#9807