-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all binaries from /usr/sbin to /usr/bin #68
Conversation
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025030306-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update
Failed tests9 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/129058#dependencies 15 fixed
Unstable testsPerformance TestsPerformance degradation:31 performance degradations
Remaining performance tests:41 tests
|
4b09725
to
b2ca33f
Compare
In practice only qubesdb-daemon remained in /usr/sbin. Since Fedora 42 merged those two, it ends up in /usr/bin anyway, and since its harmless on other distros, move it everywhere. This simplifies for example systemd unit handling (which otherwise would sometimes need /usr/bin and sometimes /usr/sbin path). But keep /usr/sbin/qubesdb-daemon compatibility symlink in RPM distros that don't merge sbin with bin yet. This especially applies to F41-based dom0, where qubesd referrs to /usr/sbin/qubesdb-daemon. QubesOS/qubes-issues#9807
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the confusing commented-out entries in .gitlab-ci.yml
, looks good to me.
# - file: /r4.3/gitlab-host-qwt.yml | ||
# project: QubesOS/qubes-continuous-integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this present but commented out? 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be uncommented when QWT tests in CI will be back.
In practice only qubesdb-daemon remained in /usr/sbin.
Since Fedora 42 merged those two, it ends up in /usr/bin anyway, and
since its harmless on other distros, move it everywhere. This simplifies
for example systemd unit handling (which otherwise would sometimes need
/usr/bin and sometimes /usr/sbin path).
QubesOS/qubes-issues#9807