Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust qvm.template_installed to use qvm-check #32

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Adjust qvm.template_installed to use qvm-check #32

merged 2 commits into from
Mar 10, 2025

Conversation

marmarek
Copy link
Member

@marmarek marmarek commented Mar 2, 2025

Use qvm-check --template to check if the template exists. This covers the
case of in-place upgraded templates, in addition to those installed with
qvm-template directly.

Fixes QubesOS/qubes-issues#9818

@marmarek marmarek force-pushed the template-installed-check branch from 6837aca to e204bee Compare March 2, 2025 09:54
@marmarek
Adjust qvm.template_installed to use qvm-check
251fe86 
Use qvm-check --template to check if the template exists. This covers
the case of in-place upgraded templates, in addition to those installed
with qvm-template directly.

Fixes QubesOS/qubes-issues#9818
@marmarek marmarek force-pushed the template-installed-check branch from e204bee to 251fe86 Compare March 2, 2025 12:37
@qubesos-bot
Copy link

qubesos-bot commented Mar 2, 2025 •
edited
Loading

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025030303-4.3-fedora&flavor=templates

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update

  • system_tests_basic_vm_qrexec_gui

  • system_tests_pvgrub_salt_storage

    • TC_41_HVMGrub_fedora-42-xfce: test_000_standalone_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_41_HVMGrub_fedora-42-xfce: test_010_template_based_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_42_PVHGrub_fedora-42-xfce: test_000_standalone_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_42_PVHGrub_fedora-42-xfce: test_010_template_based_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • system_tests_network_updates

    • TC_00_Dom0Upgrade_fedora-42-xfce: test_001_update_check (failure)
      ^... AssertionError: '1' is not false

  • system_tests_guivm_gui_interactive

    • simple_gui_apps: unnamed test (unknown)

    • simple_gui_apps: Failed (test died)
      # Test died: no candidate needle with tag(s) 'vm-settings-applicati...

    • simple_gui_apps: wait_serial (wait serial expected)
      # wait_serial expected: "lspci; echo 2E8vz-\$?-"...

    • simple_gui_apps: wait_serial (wait serial expected)
      # wait_serial expected: qr/2E8vz-\d+-/...

Failed tests

10 failures

  • system_tests_basic_vm_qrexec_gui

  • system_tests_pvgrub_salt_storage

    • TC_41_HVMGrub_fedora-42-xfce: test_000_standalone_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_41_HVMGrub_fedora-42-xfce: test_010_template_based_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_42_PVHGrub_fedora-42-xfce: test_000_standalone_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_42_PVHGrub_fedora-42-xfce: test_010_template_based_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • system_tests_network_updates

    • TC_00_Dom0Upgrade_fedora-42-xfce: test_001_update_check (failure)
      ^... AssertionError: '1' is not false

  • system_tests_guivm_gui_interactive

    • simple_gui_apps: unnamed test (unknown)

    • simple_gui_apps: Failed (test died)
      # Test died: no candidate needle with tag(s) 'vm-settings-applicati...

    • simple_gui_apps: wait_serial (wait serial expected)
      # wait_serial expected: "lspci; echo 2E8vz-\$?-"...

    • simple_gui_apps: wait_serial (wait serial expected)
      # wait_serial expected: qr/2E8vz-\d+-/...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/129058#dependencies

6 fixed

  • system_tests_audio

  • system_tests_qrexec

  • system_tests_whonix

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

Unstable tests

Performance Tests

Performance degradation:

No issues

Remaining performance tests:

No remaining performance tests

This was referenced Mar 2, 2025
Closed
Merged
Merged
Merged
@marmarek marmarek merged commit 251fe86 into QubesOS:main Mar 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
openqa-group-2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

qvm.template_installed salt state gets confused by in-place upgraded template
2 participants
@marmarek @qubesos-bot