-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Add permissioned signer functionality #14521
Merged
runtian-zhou
merged 1 commit into
main
from
09-04-implement_rust_logics_for_permissioned_signer
Jan 15, 2025
Merged
[feature] Add permissioned signer functionality #14521
runtian-zhou
merged 1 commit into
main
from
09-04-implement_rust_logics_for_permissioned_signer
Jan 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 3h 36m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
21 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 08-29-create_permissioned_signer_example #14521 +/- ##
==========================================================================
Coverage 60.1% 60.1%
==========================================================================
Files 856 857 +1
Lines 211026 210762 -264
==========================================================================
- Hits 126865 126723 -142
+ Misses 84161 84039 -122 ☔ View full report in Codecov by Sentry. |
456f5f4
to
55771fc
Compare
31c9b2c
to
6d309ff
Compare
55771fc
to
070a951
Compare
6d309ff
to
703921b
Compare
10 tasks
070a951
to
b832d3d
Compare
703921b
to
48991ff
Compare
b832d3d
to
6ddb481
Compare
48991ff
to
906c7c7
Compare
6ddb481
to
8b92b98
Compare
906c7c7
to
350db4c
Compare
21 tasks
8b92b98
to
fa646c8
Compare
350db4c
to
dad258f
Compare
10 tasks
fa646c8
to
c3aba3a
Compare
dad258f
to
6b4da66
Compare
c3aba3a
to
50b556b
Compare
6b4da66
to
b1fd015
Compare
21 tasks
50b556b
to
8cd68d5
Compare
b1fd015
to
6592c01
Compare
1835d3d
to
42decc7
Compare
This comment has been minimized.
This comment has been minimized.
23524b5
to
20fa44c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
74f33c1
to
fd6ef05
Compare
21 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fd6ef05
to
6c56a97
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6c56a97
to
95d2640
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement rust extension for the permissioned signer, including the new ser/de logic.
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
This will be tested with future PRs. Also a replay-verify is executed to make sure this feature is not breaking.
Key Areas to Review
We still need to keep the old serialization logic in the bcs module because it can otherwise cause on chain divergence.
Checklist