Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing master signer checks in coin #15737

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Removing master signer checks in coin #15737

wants to merge 4 commits into from

Conversation

runtian-zhou
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Jan 15, 2025 •
edited
Loading

⏱️ 1h 9m total CI duration on this PR
Job Cumulative Duration Recent Runs
check-dynamic-deps 33m 🟩 🟩 🟩 🟩 🟩 (+8 more)
rust-cargo-deny 22m 🟩 🟩 🟩 🟩 🟩 (+8 more)
general-lints 6m 🟩 🟩 🟩 🟩 🟩 (+8 more)
semgrep/ci 5m 🟩 🟩 🟩 🟩 🟩 (+8 more)
file_change_determinator 2m 🟩 🟩 🟩 🟩 🟩 (+8 more)
permission-check 35s 🟩 🟩 🟩 🟩 🟩 (+8 more)
permission-check 30s 🟩 🟩 🟩 🟩 🟩 (+8 more)
check-branch-prefix 1s 🟩 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

This was referenced Jan 15, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
@runtian-zhou Graphite App
Copy link
Contributor Author

runtian-zhou commented Jan 15, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@runtian-zhou runtian-zhou force-pushed the 01-10-create_object_with_permissioned_signer branch from 83738a4 to 7e5a51f Compare January 15, 2025 05:02
@runtian-zhou runtian-zhou force-pushed the 01-14-removing_master_signer_checks_in_coin branch from efd209f to 404e956 Compare January 15, 2025 05:02
@runtian-zhou runtian-zhou force-pushed the 01-10-create_object_with_permissioned_signer branch from 7e5a51f to 655447d Compare January 15, 2025 06:22
@runtian-zhou runtian-zhou force-pushed the 01-14-removing_master_signer_checks_in_coin branch from 404e956 to 09f1c26 Compare January 15, 2025 06:22
@runtian-zhou runtian-zhou force-pushed the 01-10-create_object_with_permissioned_signer branch from 655447d to 8951e21 Compare January 15, 2025 06:59
@runtian-zhou runtian-zhou force-pushed the 01-14-removing_master_signer_checks_in_coin branch from 09f1c26 to 74830e1 Compare January 15, 2025 06:59
@runtian-zhou runtian-zhou force-pushed the 01-10-create_object_with_permissioned_signer branch from 8951e21 to 217346d Compare January 15, 2025 07:08
@runtian-zhou runtian-zhou force-pushed the 01-14-removing_master_signer_checks_in_coin branch from 74830e1 to 0adc496 Compare January 15, 2025 07:08
@runtian-zhou runtian-zhou force-pushed the 01-10-create_object_with_permissioned_signer branch from 217346d to 45c2794 Compare January 15, 2025 07:36
@runtian-zhou runtian-zhou force-pushed the 01-14-removing_master_signer_checks_in_coin branch from 0adc496 to 1bfd8d8 Compare January 15, 2025 07:36
@runtian-zhou runtian-zhou force-pushed the 01-10-create_object_with_permissioned_signer branch from 45c2794 to a368fd6 Compare January 15, 2025 15:22
@runtian-zhou runtian-zhou force-pushed the 01-14-removing_master_signer_checks_in_coin branch from 1bfd8d8 to 0154fae Compare January 15, 2025 15:22
@runtian-zhou runtian-zhou force-pushed the 01-10-create_object_with_permissioned_signer branch from a368fd6 to f2d1cc7 Compare January 15, 2025 15:26
@runtian-zhou runtian-zhou force-pushed the 01-14-removing_master_signer_checks_in_coin branch from 0154fae to a651b7f Compare January 15, 2025 15:26
@runtian-zhou runtian-zhou force-pushed the 01-10-create_object_with_permissioned_signer branch from f2d1cc7 to 154c5d2 Compare January 15, 2025 15:36
@runtian-zhou runtian-zhou force-pushed the 01-14-removing_master_signer_checks_in_coin branch from a651b7f to 70ca114 Compare January 15, 2025 15:36
@runtian-zhou runtian-zhou marked this pull request as ready for review January 15, 2025 17:58
@runtian-zhou runtian-zhou requested a review from wrwg as a code owner January 15, 2025 17:58
@runtian-zhou runtian-zhou force-pushed the 01-10-create_object_with_permissioned_signer branch from 154c5d2 to 7fce8b6 Compare January 15, 2025 17:59
@runtian-zhou runtian-zhou mentioned this pull request Jan 15, 2025
Merged
@runtian-zhou runtian-zhou force-pushed the 01-14-removing_master_signer_checks_in_coin branch from 70ca114 to 82beaba Compare January 15, 2025 17:59
@runtian-zhou runtian-zhou force-pushed the 01-10-create_object_with_permissioned_signer branch from 7fce8b6 to f3c994c Compare January 15, 2025 18:28
@runtian-zhou runtian-zhou force-pushed the 01-14-removing_master_signer_checks_in_coin branch from 82beaba to 9193938 Compare January 15, 2025 18:28
@runtian-zhou runtian-zhou force-pushed the 01-10-create_object_with_permissioned_signer branch from f3c994c to 1341cdf Compare January 15, 2025 19:29
@runtian-zhou runtian-zhou force-pushed the 01-14-removing_master_signer_checks_in_coin branch from 9193938 to 9daace7 Compare January 15, 2025 19:30
@runtian-zhou runtian-zhou changed the base branch from 01-10-create_object_with_permissioned_signer to 09-11-permission_for_framework January 15, 2025 19:30
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch 2 times, most recently from b39c2b7 to 468fc3a Compare January 15, 2025 20:33
@runtian-zhou runtian-zhou force-pushed the 09-11-permission_for_framework branch from be925c2 to 5b37244 Compare January 15, 2025 20:46
@runtian-zhou runtian-zhou force-pushed the 01-14-removing_master_signer_checks_in_coin branch from 9daace7 to 24c7346 Compare January 15, 2025 21:08
@runtian-zhou runtian-zhou changed the base branch from 09-11-permission_for_framework to asset_permission January 15, 2025 21:08
@runtian-zhou runtian-zhou force-pushed the asset_permission branch 4 times, most recently from 99580a8 to 9b13784 Compare January 16, 2025 03:38
Base automatically changed from asset_permission to main January 16, 2025 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igor-aptos igor-aptos igor-aptos approved these changes

@davidiw davidiw Awaiting requested review from davidiw davidiw is a code owner

@movekevin movekevin Awaiting requested review from movekevin movekevin is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg is a code owner

@junkil-park junkil-park Awaiting requested review from junkil-park junkil-park is a code owner

@alinush alinush Awaiting requested review from alinush alinush is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@runtian-zhou @igor-aptos