add permissions for fungible assets operation #14567

runtian-zhou · 2024-09-09T17:09:32Z

Description

Implemented permissions for FA transfer.

Work with current Coin that already migrated to FA as well.
Implemented a new api deposit_with_signer so that permissions can be added to the signer back again.

Type of Change

Which Components or Systems Does This Change Impact?

How Has This Been Tested?

Added test cases. In particular, tested the entire migration path of Coin and FA.

Key Areas to Review

Make sure FA permission works well throughout the entire migration path of FA.

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-09-09T17:09:35Z

⏱️ 2h 19m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
rust-move-unit-coverage	18m	🟩
rust-move-unit-coverage	15m	🟩
rust-move-unit-coverage	15m	🟩
rust-move-unit-coverage	15m	🟩
check-dynamic-deps	12m	🟩 🟩 🟩 🟩 🟩 (+2 more)
general-lints	10m	🟩 🟩 🟩 🟩 🟩
rust-move-tests	9m	🟥
rust-move-tests	9m	🟥
rust-cargo-deny	9m	🟩 🟩 🟩 🟩 🟩
rust-move-tests	8m	🟥
rust-move-unit-coverage	4m	⬜
rust-move-tests	4m	⬜
semgrep/ci	4m	🟩 🟩 🟩 🟩 🟩 (+5 more)
rust-move-tests	3m	🟥
file_change_determinator	1m	🟩 🟩 🟩 🟩 🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

runtian-zhou · 2024-09-09T17:09:44Z

add permissions for fungible assets operation #14567 : 2 dependent PRs (#14605 , #15737 ) 👈 (View in Graphite)
Add permission checks to account #15741
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2024-09-09T17:24:38Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.1%. Comparing base (7c5a356) to head (bb315dd).

Additional details and impacted files

@@                                 Coverage Diff                                  @@
##           09-04-implement_rust_logics_for_permissioned_signer   #14567   +/-   ##
====================================================================================
  Coverage                                                 60.1%    60.1%           
====================================================================================
  Files                                                      857      857           
  Lines                                                   210762   210762           
====================================================================================
+ Hits                                                    126723   126744   +21     
+ Misses                                                   84039    84018   -21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

igor-aptos · 2025-01-15T19:47:09Z

aptos-move/framework/aptos-framework/sources/coin.move

@@ -616,6 +617,7 @@ module aptos_framework::coin {
    public entry fun migrate_to_fungible_store<CoinType>(
        account: &signer
    ) acquires CoinStore, CoinConversionMap, CoinInfo {
+        permissioned_signer::assert_master_signer(account);


maybe this shouldn't require any permissions?

igor-aptos · 2025-01-15T19:47:28Z

aptos-move/framework/aptos-framework/sources/coin.move

@@ -1016,6 +1019,7 @@ module aptos_framework::coin {
    }

    public fun register<CoinType>(account: &signer) acquires CoinConversionMap {
+        permissioned_signer::assert_master_signer(account);


let's add TODO here to move this to FA Withdraw(0) permission

github-actions · 2025-01-16T04:03:19Z

✅ Forge suite `realistic_env_max_load` success on `9b137848277806bd2cdd2b2b129fd6fe4e789a78`

two traffics test: inner traffic : committed: 14793.75 txn/s, submitted: 14793.80 txn/s, expired: 0.05 txn/s, latency: 2682.55 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5624920
two traffics test : committed: 99.99 txn/s, latency: 1407.46 ms, (p50: 1300 ms, p70: 1300, p90: 1600 ms, p99: 6600 ms), latency samples: 1700
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.572, avg: 1.445", "ConsensusProposalToOrdered: max: 0.302, avg: 0.291", "ConsensusOrderedToCommit: max: 0.328, avg: 0.319", "ConsensusProposalToCommit: max: 0.620, avg: 0.610"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.20s no progress at version 25425 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.56s no progress at version 2887301 (avg 0.56s) [limit 16].
Test Ok

github-actions · 2025-01-16T04:06:18Z

✅ Forge suite `compat` success on `f69dc31b0f674662b6bfa941dc7eee9ce9035e29` ==> `9b137848277806bd2cdd2b2b129fd6fe4e789a78`

Compatibility test results for f69dc31b0f674662b6bfa941dc7eee9ce9035e29 ==> 9b137848277806bd2cdd2b2b129fd6fe4e789a78 (PR)
1. Check liveness of validators at old version: f69dc31b0f674662b6bfa941dc7eee9ce9035e29
compatibility::simple-validator-upgrade::liveness-check : committed: 15823.35 txn/s, latency: 2005.15 ms, (p50: 2000 ms, p70: 2100, p90: 2400 ms, p99: 3300 ms), latency samples: 525180
2. Upgrading first Validator to new version: 9b137848277806bd2cdd2b2b129fd6fe4e789a78
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4971.00 txn/s, latency: 6221.56 ms, (p50: 7000 ms, p70: 7500, p90: 7800 ms, p99: 7900 ms), latency samples: 99020
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4967.48 txn/s, latency: 6937.26 ms, (p50: 7700 ms, p70: 7800, p90: 8000 ms, p99: 8100 ms), latency samples: 176080
3. Upgrading rest of first batch to new version: 9b137848277806bd2cdd2b2b129fd6fe4e789a78
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4834.29 txn/s, latency: 5923.41 ms, (p50: 6100 ms, p70: 7100, p90: 7800 ms, p99: 8100 ms), latency samples: 102740
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4735.92 txn/s, latency: 7258.29 ms, (p50: 8000 ms, p70: 8100, p90: 8100 ms, p99: 8400 ms), latency samples: 170880
4. upgrading second batch to new version: 9b137848277806bd2cdd2b2b129fd6fe4e789a78
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9462.45 txn/s, latency: 3234.12 ms, (p50: 3800 ms, p70: 3900, p90: 4000 ms, p99: 4200 ms), latency samples: 166980
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9494.22 txn/s, latency: 3602.01 ms, (p50: 3800 ms, p70: 4000, p90: 4200 ms, p99: 4400 ms), latency samples: 309920
5. check swarm health
Compatibility test for f69dc31b0f674662b6bfa941dc7eee9ce9035e29 ==> 9b137848277806bd2cdd2b2b129fd6fe4e789a78 passed
Test Ok

* TMP * add permissions for fungible assets operation

runtian-zhou force-pushed the asset_permission branch from dec4a79 to 6cd5fd0 Compare September 9, 2024 17:55

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 350db4c to dad258f Compare September 10, 2024 17:25

runtian-zhou force-pushed the asset_permission branch from 6cd5fd0 to 88ad9a1 Compare September 10, 2024 17:25

runtian-zhou mentioned this pull request Sep 10, 2024

[object] Add permissioned checks to object #14582

Merged

10 tasks

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from dad258f to 6b4da66 Compare September 10, 2024 17:29

runtian-zhou force-pushed the asset_permission branch from 88ad9a1 to 5f90e3a Compare September 10, 2024 17:29

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 6b4da66 to b1fd015 Compare September 12, 2024 01:50

runtian-zhou force-pushed the asset_permission branch from 5f90e3a to ef7be0f Compare September 12, 2024 01:50

This was referenced Sep 12, 2024

create permissioned signer example #14469

Merged

[feature] Add permissioned signer functionality #14521

Merged

Add permission check to account #14535

Merged

permission for framework #14605

Merged

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from b1fd015 to 6592c01 Compare September 17, 2024 05:08

runtian-zhou force-pushed the asset_permission branch from ef7be0f to cd6090b Compare September 17, 2024 05:09

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 6592c01 to 54c34ad Compare September 17, 2024 21:23

runtian-zhou force-pushed the asset_permission branch from cd6090b to 0df1c5a Compare September 17, 2024 21:23

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 54c34ad to 1835d3d Compare September 18, 2024 06:22

runtian-zhou force-pushed the asset_permission branch from 0df1c5a to 1bd468b Compare September 18, 2024 06:23

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 1835d3d to 42decc7 Compare September 18, 2024 17:52

runtian-zhou force-pushed the asset_permission branch from 1bd468b to 40796a4 Compare September 18, 2024 17:52

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 42decc7 to 6ac9449 Compare September 19, 2024 00:35

runtian-zhou force-pushed the asset_permission branch from 40796a4 to 4940d7d Compare September 19, 2024 00:35

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 6ac9449 to 3ae6a87 Compare September 19, 2024 08:08

runtian-zhou force-pushed the asset_permission branch from 4940d7d to d8742c4 Compare September 19, 2024 08:08

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 3ae6a87 to 7fbfa3e Compare October 4, 2024 20:56

runtian-zhou force-pushed the asset_permission branch from d8742c4 to 5d53f18 Compare October 4, 2024 20:56

runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 7fbfa3e to f3015ce Compare October 5, 2024 01:54

runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from f8c3ecb to d3219e1 Compare January 15, 2025 17:56

runtian-zhou mentioned this pull request Jan 15, 2025

Add permission checks to account #15741

Merged

runtian-zhou force-pushed the asset_permission branch from e128a8b to df75ba7 Compare January 15, 2025 17:58

runtian-zhou changed the base branch from 12-17-feature_gate_permissioned_signer to runtianz/account_perms January 15, 2025 17:58

runtian-zhou force-pushed the runtianz/account_perms branch from 3e9ee91 to 6a823bf Compare January 15, 2025 18:26

runtian-zhou force-pushed the asset_permission branch from df75ba7 to 7ca3104 Compare January 15, 2025 18:27

igor-aptos added CICD:run-execution-performance-test Run execution performance test CICD:run-execution-performance-full-test Run execution performance test (full version) labels Jan 15, 2025

runtian-zhou force-pushed the runtianz/account_perms branch from 9eb6bd0 to 000d361 Compare January 15, 2025 20:46

runtian-zhou force-pushed the asset_permission branch 2 times, most recently from 3a6c8a2 to 5522b36 Compare January 15, 2025 21:42

igor-aptos approved these changes Jan 16, 2025

View reviewed changes

runtian-zhou force-pushed the runtianz/account_perms branch from 3cb1cd0 to 519d733 Compare January 16, 2025 01:23

runtian-zhou force-pushed the asset_permission branch from 5522b36 to 91bff0f Compare January 16, 2025 01:23

Base automatically changed from runtianz/account_perms to main January 16, 2025 02:29

runtian-zhou enabled auto-merge (squash) January 16, 2025 02:45

This comment has been minimized.

Sign in to view

runtian-zhou force-pushed the asset_permission branch from 91bff0f to 99580a8 Compare January 16, 2025 03:29

add permissions for fungible assets operation

9b13784

runtian-zhou force-pushed the asset_permission branch from 99580a8 to 9b13784 Compare January 16, 2025 03:38

This comment has been minimized.

Sign in to view

runtian-zhou merged commit 7ecc8ad into main Jan 16, 2025
46 checks passed

runtian-zhou deleted the asset_permission branch January 16, 2025 04:34

grao1991 pushed a commit that referenced this pull request Jan 16, 2025

add permissions for fungible assets operation (#14567)

8a329cf

* TMP * add permissions for fungible assets operation

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add permissions for fungible assets operation #14567

add permissions for fungible assets operation #14567

runtian-zhou commented Sep 9, 2024 •

edited

Loading

trunk-io bot commented Sep 9, 2024 •

edited

Loading

runtian-zhou commented Sep 9, 2024 •

edited

Loading

codecov bot commented Sep 9, 2024 •

edited

Loading

igor-aptos Jan 15, 2025

igor-aptos Jan 15, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

add permissions for fungible assets operation #14567

add permissions for fungible assets operation #14567

Conversation

runtian-zhou commented Sep 9, 2024 • edited Loading

Description

Type of Change

Which Components or Systems Does This Change Impact?

How Has This Been Tested?

Key Areas to Review

Checklist

trunk-io bot commented Sep 9, 2024 • edited Loading

runtian-zhou commented Sep 9, 2024 • edited Loading

codecov bot commented Sep 9, 2024 • edited Loading

Codecov Report

igor-aptos Jan 15, 2025

Choose a reason for hiding this comment

igor-aptos Jan 15, 2025

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 16, 2025

✅ Forge suite realistic_env_max_load success on 9b137848277806bd2cdd2b2b129fd6fe4e789a78

github-actions bot commented Jan 16, 2025

✅ Forge suite compat success on f69dc31b0f674662b6bfa941dc7eee9ce9035e29 ==> 9b137848277806bd2cdd2b2b129fd6fe4e789a78

runtian-zhou commented Sep 9, 2024 •

edited

Loading

trunk-io bot commented Sep 9, 2024 •

edited

Loading

runtian-zhou commented Sep 9, 2024 •

edited

Loading

codecov bot commented Sep 9, 2024 •

edited

Loading

✅ Forge suite `realistic_env_max_load` success on `9b137848277806bd2cdd2b2b129fd6fe4e789a78`

✅ Forge suite `compat` success on `f69dc31b0f674662b6bfa941dc7eee9ce9035e29` ==> `9b137848277806bd2cdd2b2b129fd6fe4e789a78`