Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permission checks to account #15741

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Add permission checks to account #15741

merged 1 commit into from
Jan 16, 2025

Conversation

runtian-zhou
Copy link
Contributor

@runtian-zhou runtian-zhou commented Jan 15, 2025

Duplicate of #14535

Copy link

trunk-io bot commented Jan 15, 2025

⏱️ 6h 42m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 3h 14m 🟥🟥🟥🟥🟩 (+4 more)
rust-smoke-tests 30m
test-target-determinator 23m 🟩🟩🟩🟩🟩
execution-performance / test-target-determinator 23m 🟩🟩🟩🟩🟩
rust-targeted-unit-tests 21m 🟩
check-dynamic-deps 19m 🟩🟩🟩🟩🟩 (+2 more)
forge-e2e-test / forge 13m 🟩
rust-images / rust-all 12m 🟩
rust-cargo-deny 12m 🟩🟩🟩🟩🟩 (+2 more)
fetch-last-released-docker-image-tag 9m 🟩🟩🟩🟩🟩
rust-doc-tests 6m 🟩
rust-doc-tests 6m 🟩
rust-doc-tests 6m 🟩
rust-doc-tests 6m 🟩
rust-doc-tests 5m 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

runtian-zhou commented Jan 15, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@runtian-zhou runtian-zhou changed the title TMP Add permission checks to account Jan 15, 2025
@runtian-zhou runtian-zhou marked this pull request as ready for review January 15, 2025 17:57
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from d3219e1 to 4be61e5 Compare January 15, 2025 18:25
@runtian-zhou runtian-zhou force-pushed the runtianz/account_perms branch from 3e9ee91 to 6a823bf Compare January 15, 2025 18:26
@runtian-zhou runtian-zhou changed the base branch from 12-17-feature_gate_permissioned_signer to main January 15, 2025 18:27
@runtian-zhou runtian-zhou enabled auto-merge (squash) January 15, 2025 18:38

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@runtian-zhou runtian-zhou force-pushed the runtianz/account_perms branch from 9eb6bd0 to 000d361 Compare January 15, 2025 20:46

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@runtian-zhou runtian-zhou force-pushed the runtianz/account_perms branch from 3cb1cd0 to 519d733 Compare January 16, 2025 01:23
Comment on lines +183 to +184
/// Current permissioned signer cannot perform the privilaged operations.
const ENO_ACCOUNT_PERMISSION: u64 = 23;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a typo in the error description - privilaged should be spelled privileged

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on f69dc31b0f674662b6bfa941dc7eee9ce9035e29 ==> 519d733db17b49c1feec208b56f3685e5d85d88f

Compatibility test results for f69dc31b0f674662b6bfa941dc7eee9ce9035e29 ==> 519d733db17b49c1feec208b56f3685e5d85d88f (PR)
1. Check liveness of validators at old version: f69dc31b0f674662b6bfa941dc7eee9ce9035e29
compatibility::simple-validator-upgrade::liveness-check : committed: 17151.50 txn/s, latency: 1843.84 ms, (p50: 1900 ms, p70: 1900, p90: 2200 ms, p99: 3100 ms), latency samples: 549540
2. Upgrading first Validator to new version: 519d733db17b49c1feec208b56f3685e5d85d88f
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5066.41 txn/s, latency: 6057.45 ms, (p50: 6800 ms, p70: 7400, p90: 7600 ms, p99: 7800 ms), latency samples: 100000
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5081.83 txn/s, latency: 6778.26 ms, (p50: 7500 ms, p70: 7600, p90: 7800 ms, p99: 7800 ms), latency samples: 177540
3. Upgrading rest of first batch to new version: 519d733db17b49c1feec208b56f3685e5d85d88f
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5186.85 txn/s, latency: 5935.43 ms, (p50: 6700 ms, p70: 7200, p90: 7400 ms, p99: 7400 ms), latency samples: 101500
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5109.53 txn/s, latency: 6729.78 ms, (p50: 7400 ms, p70: 7500, p90: 7500 ms, p99: 7600 ms), latency samples: 178940
4. upgrading second batch to new version: 519d733db17b49c1feec208b56f3685e5d85d88f
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9307.19 txn/s, latency: 3280.36 ms, (p50: 3800 ms, p70: 4000, p90: 4300 ms, p99: 4400 ms), latency samples: 165800
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9357.32 txn/s, latency: 3665.62 ms, (p50: 3900 ms, p70: 4000, p90: 4200 ms, p99: 4400 ms), latency samples: 307180
5. check swarm health
Compatibility test for f69dc31b0f674662b6bfa941dc7eee9ce9035e29 ==> 519d733db17b49c1feec208b56f3685e5d85d88f passed
Test Ok

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 519d733db17b49c1feec208b56f3685e5d85d88f

two traffics test: inner traffic : committed: 14901.86 txn/s, submitted: 14902.23 txn/s, expired: 0.37 txn/s, latency: 2661.45 ms, (p50: 2700 ms, p70: 2700, p90: 2800 ms, p99: 3300 ms), latency samples: 5666280
two traffics test : committed: 100.00 txn/s, latency: 1296.79 ms, (p50: 1300 ms, p70: 1300, p90: 1400 ms, p99: 1600 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.546, avg: 1.495", "ConsensusProposalToOrdered: max: 0.299, avg: 0.289", "ConsensusOrderedToCommit: max: 0.307, avg: 0.299", "ConsensusProposalToCommit: max: 0.594, avg: 0.588"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.21s no progress at version 21617 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.85s no progress at version 6412026 (avg 0.69s) [limit 16].
Test Ok

@runtian-zhou runtian-zhou merged commit 7214377 into main Jan 16, 2025
43 of 46 checks passed
@runtian-zhou runtian-zhou deleted the runtianz/account_perms branch January 16, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants