-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add permission checks to account #15741
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 6h 42m total CI duration on this PR
|
This was referenced Jan 15, 2025
Merged
This stack of pull requests is managed by Graphite. Learn more about stacking. |
runtian-zhou
requested review from
junkil-park,
alinush,
davidiw,
movekevin and
wrwg
as code owners
January 15, 2025 17:57
igor-aptos
approved these changes
Jan 15, 2025
runtian-zhou
force-pushed
the
12-17-feature_gate_permissioned_signer
branch
from
January 15, 2025 18:25
d3219e1
to
4be61e5
Compare
runtian-zhou
force-pushed
the
runtianz/account_perms
branch
from
January 15, 2025 18:26
3e9ee91
to
6a823bf
Compare
runtian-zhou
changed the base branch from
12-17-feature_gate_permissioned_signer
to
main
January 15, 2025 18:27
rahxephon89
approved these changes
Jan 15, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
runtian-zhou
force-pushed
the
runtianz/account_perms
branch
from
January 15, 2025 20:46
9eb6bd0
to
000d361
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
runtian-zhou
force-pushed
the
runtianz/account_perms
branch
from
January 16, 2025 01:23
3cb1cd0
to
519d733
Compare
Comment on lines
+183
to
+184
/// Current permissioned signer cannot perform the privilaged operations. | ||
const ENO_ACCOUNT_PERMISSION: u64 = 23; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a typo in the error description - privilaged
should be spelled privileged
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #14535