Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(goal_planner): fix updateData continuation condition #10079

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Feb 6, 2025

Description

depends #10066

Related links

Parent Issue:

  • Link

How was this PR tested?

4 failed cases are caused by undefined reference to..., so they are ignorable

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@soblin soblin marked this pull request as ready for review February 7, 2025 04:31
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 7, 2025
@soblin soblin force-pushed the refactor/goal-planner/updateData branch from 5f3fe43 to a9beefa Compare February 7, 2025 04:31
@soblin soblin enabled auto-merge (squash) February 7, 2025 04:31
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.30%. Comparing base (08b007c) to head (a9beefa).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10079      +/-   ##
==========================================
- Coverage   28.31%   28.30%   -0.02%     
==========================================
  Files        1485     1488       +3     
  Lines      111087   111148      +61     
  Branches    43149    43150       +1     
==========================================
  Hits        31458    31458              
- Misses      76608    76669      +61     
  Partials     3021     3021              
Flag Coverage Δ *Carryforward flag
differential 0.50% <0.00%> (?)
total 28.31% <ø> (+<0.01%) ⬆️ Carriedforward from 08b007c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit f3d1590 into autowarefoundation:main Feb 7, 2025
34 checks passed
@soblin soblin deleted the refactor/goal-planner/updateData branch February 7, 2025 06:15
soblin added a commit to tier4/autoware.universe that referenced this pull request Feb 12, 2025
…refoundation#10079)

refactor(goal_planner): fix updateData contiuation condition

Signed-off-by: Mamoru Sobue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants