Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(goal_planner): fix updateData continuation condition #10079

Merged

refactor(goal_planner): fix updateData contiuation condition

a9beefa
Select commit
Loading
Failed to load commit list.
Merged

refactor(goal_planner): fix updateData continuation condition #10079

refactor(goal_planner): fix updateData contiuation condition
a9beefa
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Feb 7, 2025 in 41s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.00 (3.53 -> 3.53)

  • Improving Code Health: 2 findings(s) ✅
  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Overall Code Complexity goal_planner_module.cpp 🔥
  • Complex Method goal_planner_module.cpp: GoalPlannerModule::updateData 🔥

Annotations

Check notice on line 749 in planning/behavior_path_planner/autoware_behavior_path_goal_planner_module/src/goal_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Complex Method

GoalPlannerModule::updateData decreases in cyclomatic complexity from 20 to 19, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in planning/behavior_path_planner/autoware_behavior_path_goal_planner_module/src/goal_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Overall Code Complexity

The mean cyclomatic complexity decreases from 6.48 to 6.46, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.