Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tensorrt_yolox): add launch for tlr model #9828

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Jan 6, 2025

Description

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: badai-nguyen <[email protected]>
@badai-nguyen badai-nguyen added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 14, 2025
@badai-nguyen badai-nguyen marked this pull request as ready for review January 14, 2025 02:04
Copy link
Contributor

@ktro2828 ktro2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed this change works.

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but could you update README about what integer will be asigned as car/pedestrian traffic signal?

@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Jan 16, 2025
@badai-nguyen badai-nguyen force-pushed the feat/tensorrt_yolox/add_tl_launch branch from 1d22dd4 to d3215c5 Compare January 16, 2025 08:17
@badai-nguyen
Copy link
Contributor Author

LGTM but could you update README about what integer will be asigned as car/pedestrian traffic signal?

@YoshiRi I update here d3215c5

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MasatoSaeki MasatoSaeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much.

@badai-nguyen badai-nguyen enabled auto-merge (squash) January 21, 2025 11:58
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.43%. Comparing base (daf9ccd) to head (4131e8b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9828      +/-   ##
==========================================
- Coverage   29.44%   29.43%   -0.01%     
==========================================
  Files        1417     1417              
  Lines      107419   107429      +10     
  Branches    42562    42566       +4     
==========================================
  Hits        31626    31626              
- Misses      72716    72726      +10     
  Partials     3077     3077              
Flag Coverage Δ *Carryforward flag
differential-cuda 0.00% <ø> (?)
total 29.44% <ø> (ø) Carriedforward from daf9ccd

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badai-nguyen badai-nguyen merged commit 2c9a587 into autowarefoundation:main Jan 21, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants