Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new tl detector artifacts download #5626

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Jan 6, 2025

Description

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Jan 6, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

@MasatoSaeki MasatoSaeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I checked this PR following https://github.com/autowarefoundation/autoware/tree/main/ansible/roles/artifacts.
And also checked this file is used by autoware_tensorrt_yolox like command ros2 launch autoware_tensorrt_yolox yolox_traffic_light_detector.launch.xml .

@badai-nguyen
Copy link
Contributor Author

@youtalk @oguzkaganozt Could you review this PR as codeowner? If there is no any concern, I would like to merge this PR since the the related PR was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants