chore(ci): fix cpplint errors from pre-commit ci

[mitsudome-r]

Description

This PR fixes errors from cpplint in pre-commit ci.
When #4 was merged, // NOLINTNEXTLINE was used to suppress errors.

However, cpplint in version 1.6.1 does not recognize cppcoreguidelines-pro-bounds-pointer-arithmetic as a supported category and outputs the following error when you run pre-commit run -a

cpplint..................................................................Failed
- hook id: cpplint
- exit code: 1

autoware_lanelet2_extension_python/src/utility.cpp:70:  Unknown NOLINT error category: cppcoreguidelines-pro-bounds-pointer-arithmetic  [readability/nolint] [5]
autoware_lanelet2_extension_python/src/utility.cpp:86:  Unknown NOLINT error category: cppcoreguidelines-pro-bounds-pointer-arithmetic  [readability/nolint] [5]
autoware_lanelet2_extension_python/src/utility.cpp:103:  Unknown NOLINT error category: cppcoreguidelines-pro-bounds-pointer-arithmetic  [readability/nolint] [5]
autoware_lanelet2_extension_python/src/utility.cpp:120:  Unknown NOLINT error category: cppcoreguidelines-pro-bounds-pointer-arithmetic  [readability/nolint] [5]
autoware_lanelet2_extension_python/src/utility.cpp:142:  Unknown NOLINT error category: cppcoreguidelines-pro-bounds-pointer-arithmetic  [readability/nolint] [5]
autoware_lanelet2_extension_python/src/utility.cpp:159:  Unknown NOLINT error category: cppcoreguidelines-pro-bounds-pointer-arithmetic  [readability/nolint] [5]
autoware_lanelet2_extension_python/src/utility.cpp:243:  Unknown NOLINT error category: cppcoreguidelines-pro-bounds-pointer-arithmetic  [readability/nolint] [5]
autoware_lanelet2_extension_python/src/utility.cpp:261:  Unknown NOLINT error category: cppcoreguidelines-pro-bounds-pointer-arithmetic  [readability/nolint] [5]
autoware_lanelet2_extension_python/src/utility.cpp:279:  Unknown NOLINT error category: cppcoreguidelines-pro-bounds-pointer-arithmetic  [readability/nolint] [5]
autoware_lanelet2_extension_python/src/utility.cpp:296:  Unknown NOLINT error category: cppcoreguidelines-pro-bounds-pointer-arithmetic  [readability/nolint] [5]
autoware_lanelet2_extension_python/src/utility.cpp:319:  Unknown NOLINT error category: cppcoreguidelines-pro-bounds-pointer-arithmetic  [readability/nolint] [5]
autoware_lanelet2_extension_python/src/utility.cpp:341:  Unknown NOLINT error category: cppcoreguidelines-pro-bounds-pointer-arithmetic  [readability/nolint] [5]
autoware_lanelet2_extension_python/src/utility.cpp:360:  Unknown NOLINT error category: cppcoreguidelines-pro-bounds-pointer-arithmetic  [readability/nolint] [5]
Done processing autoware_lanelet2_extension_python/src/utility.cpp
Total errors found: 13

We can instead use NOLINTBEGIN to generally ignore the lint for relevant lines.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[mitsudome-r]

An alternative way is to reconfigure cpplint to remove the check for cppcoreguidelines-pro-bounds-pointer-arithmetic and rely on clang-tidy.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (3a8bde9) to head (b503a08).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #15       +/-   ##
==========================================
- Coverage   15.93%   0.00%   -15.94%     
==========================================
  Files          40      40               
  Lines        2748    2737       -11     
  Branches     1339     463      -876     
==========================================
- Hits          438       0      -438     
- Misses       2222    2737      +515     
+ Partials       88       0       -88     

Flag	Coverage Δ
differential	0.00% <ø> (-15.94%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[HansRobo]

@mitsudome-r You can use NOLINTBEGIN with newer version of cpplint like ibis-ssl/crane#442
Google has already ended support for the public cpplint and there hasn't been a new release for two years, so to use new features, it's appropriate to specify a commit hash.

[esteve]

@mitsudome-r LGTM, thanks

[youtalk]

LGTM
It's my fault. Thank you for the fix.