Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add autoware_ prefix to package names and namespaces #3

Merged
merged 14 commits into from
May 7, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented May 2, 2024

This PR has added autoware_ prefix to the packages.
It is because the original package names have too large namespace to be released from the ROS build farm.

ref. https://github.com/orgs/autowarefoundation/discussions/4671

youtalk added 13 commits May 2, 2024 19:25
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
This reverts commit 8079660.

Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk force-pushed the add-autoware-prefix branch from fc799bc to 894c857 Compare May 2, 2024 10:26
@youtalk youtalk marked this pull request as ready for review May 2, 2024 11:00
@youtalk
Copy link
Member Author

youtalk commented May 7, 2024

@kosuke55 @soblin @Motsu-san @mitsudome-r @takayuki5168
Please review this. I will release the autoware_lanelet2_extension and autoware_lanele2_extension_python from the ROS build firm. The namespace changes is required to do it.

@youtalk youtalk self-assigned this May 7, 2024
Copy link
Collaborator

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good

( I did not catch up migration timing or detailed disucussion.
just for my memo. tier4 internal discussion link

Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youtalk youtalk merged commit 90d7d2a into autowarefoundation:main May 7, 2024
11 checks passed
@youtalk youtalk deleted the add-autoware-prefix branch May 7, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants