Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
A
TransparentUI
phase's items all target the same camera so there is no need to store the current camera entity inUiBatch
and ending the currentUiBatch
on camera changes is pointless as the camera doesn't change.Solution
Remove the
camera
fields fromUiBatch
,UiShadowsBatch
andUiTextureSliceBatch
.Remove the camera changed check from
prepare_uinodes
.Testing
The
multiple_windows
andsplit_screen
examples both render UI elements to multiple cameras and can be used to test these changes.The UI material plugin already didn't store the camera entity per batch and worked fine without it.