Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate @bpmn-io/draggle #588

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Integrate @bpmn-io/draggle #588

merged 2 commits into from
Aug 2, 2023

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Mar 30, 2023

This uses an updated dragula version to make the direction dynamic. It detects whether the drop would happen inside a row or not and change the direction accordingly.

This makes drag & drop quite a bit smoother as it uses the correct axis depending where the cursor is located. Beforehand it would always have used the y-axis.

Depends on bpmn-io/draggle#1

Demo: https://demo-improve-dragging--camunda-form-playground.netlify.app/

Kapture 2023-03-30 at 13 59 19

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Mar 30, 2023
@github-actions github-actions bot temporarily deployed to demo-improve-dragging March 30, 2023 11:56 Destroyed
@github-actions github-actions bot temporarily deployed to demo-improve-dragging March 30, 2023 11:56 Destroyed
@pinussilvestrus
Copy link
Contributor Author

Note that we likely need a fork for customizations, as the dragula project is pretty much not maintained at the moment. That might change once dragula@2 comes to live, but there is no timeline for this.

@toofff
Copy link

toofff commented Apr 4, 2023

Hi 👋

For the moment I don't have a release date for Dragula2 but I will have a little more time this month to finalize part of my roadmap. If an alpha is possible, I'll let you know if you like?

For information, I started this redesign project because I also wanted to have an official integration of the "drag cursor position offset" functionality.

@pinussilvestrus
Copy link
Contributor Author

pinussilvestrus commented Apr 4, 2023

Hi @toofff, thanks for reaching out! We'd love to try out your alpha version once available 🚀 The position offset is actually something we would like to use, as we identified it already while integrating dragula.

Let's stay in contact 👍

@pinussilvestrus
Copy link
Contributor Author

pinussilvestrus commented Apr 4, 2023

An evidence why we should have a look at this PR, soo : #591 (comment)

/cc @RomanKostka @christian-konrad

@pinussilvestrus pinussilvestrus added backlog Queued in backlog and removed in progress Currently worked on labels Apr 25, 2023
@github-actions github-actions bot temporarily deployed to demo-improve-dragging April 25, 2023 07:30 Destroyed
@github-actions github-actions bot temporarily deployed to demo-improve-dragging July 28, 2023 10:07 Destroyed
@pinussilvestrus
Copy link
Contributor Author

pinussilvestrus commented Jul 28, 2023

Using our own fork started via bpmn-io/draggle#1

@pinussilvestrus pinussilvestrus mentioned this pull request Jul 28, 2023
4 tasks
@github-actions github-actions bot temporarily deployed to demo-improve-dragging August 1, 2023 09:44 Destroyed
@github-actions github-actions bot temporarily deployed to demo-improve-dragging August 1, 2023 11:29 Destroyed
@pinussilvestrus pinussilvestrus changed the title wip experimental dragula version Integrate @bpmn-io/draggle Aug 1, 2023
@pinussilvestrus pinussilvestrus marked this pull request as ready for review August 1, 2023 11:34
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed backlog Queued in backlog labels Aug 1, 2023
@github-actions github-actions bot temporarily deployed to demo-improve-dragging August 1, 2023 11:35 Destroyed
@pinussilvestrus
Copy link
Contributor Author

This is ready for review now 🎉

Copy link

@RomanKostka RomanKostka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from my side - very smoothly!

@pinussilvestrus pinussilvestrus merged commit 3476736 into develop Aug 2, 2023
11 of 12 checks passed
@pinussilvestrus pinussilvestrus deleted the improve-dragging branch August 2, 2023 09:22
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants