Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move Android package ID from build.gradle to package.json #153

Closed
wants to merge 7 commits into from
Closed

move Android package ID from build.gradle to package.json #153

wants to merge 7 commits into from

Conversation

brodycj
Copy link
Owner

@brodycj brodycj commented Sep 22, 2019 •
edited
Loading

(updated)

in order to make the android/build.gradle artifact 100% generic

i.e. rendered directly from the template, with zero module-specific customization

resolves the following TODO item in #19:

fix generated android/build.gradle to read and use the packageIdentifier value from package.json, in order to make this Android build artifact zero percent customized

todo:

  • test with generated example on most recent React Native version (0.62 at the time of this update)
  • test with generated example on an older React Native version such as 0.61 or 0.60

@brodycj brodycj self-assigned this Sep 22, 2019
@brodycj brodycj force-pushed the with-native-section branch 2 times, most recently from 7ff4e44 to 7e8cb06 Compare September 22, 2019 20:18
@brodycj brodycj marked this pull request as ready for review September 22, 2019 20:20
@brodycj brodycj mentioned this pull request Sep 22, 2019
Draft
4 tasks
@brodycj brodycj changed the base branch from dev to master November 15, 2019 05:38
@brodycj
add native item with package ID to package.json
662bb75 
in order to make the `android/build.gradle` artifact 100% generic

i.e. rendered directly from the template,
with zero module-specific customization
@brodycj
make it android item with the packageIdentifier field in `package…
4b320e9 
….json`
@brodycj
update test snapshots
16bfdcc
@brodycj brodycj changed the title add native item with package ID to package.json add native item with Android package ID to package.json Apr 2, 2020
@brodycj brodycj changed the title add native item with Android package ID to package.json [WIP] add native item with Android package ID to package.json Apr 2, 2020
@brodycj brodycj marked this pull request as draft July 12, 2020 22:48
@brodycj brodycj changed the title [WIP] add native item with Android package ID to package.json configure native Android package ID item in package.json Aug 13, 2020
@brodycj brodycj changed the title configure native Android package ID item in package.json move native Android package ID item into package.json Aug 13, 2020
@brodycj brodycj mentioned this pull request Aug 14, 2020
Closed
@brodycj brodycj changed the title move native Android package ID item into package.json move Android package ID from build.gradle to package.json Feb 10, 2021
@brodycj
Copy link
Owner Author

brodycj commented Feb 10, 2021

I am not planning to merge this. From PR #403 we can see that the Android package ID will not be needed in build.gradle by default.

@brodycj brodycj closed this Feb 10, 2021
@brodycj brodycj deleted the with-native-section branch February 10, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brodycj brodycj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brodycj