Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move Android package ID from build.gradle to package.json #153

Closed
wants to merge 7 commits into from
Closed

move Android package ID from build.gradle to package.json #153

wants to merge 7 commits into from

Commits on Apr 2, 2020

  1. add native item with package ID to package.json 

    in order to make the `android/build.gradle` artifact 100% generic

i.e. rendered directly from the template,
with zero module-specific customization
    @brodycj
    brodycj committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    662bb75 View commit details
    Browse the repository at this point in the history

  2. make it android item with the packageIdentifier field in `package… 

    ….json`
    @brodycj
    brodycj committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    4b320e9 View commit details
    Browse the repository at this point in the history

  3. update test snapshots

    @brodycj
    brodycj committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    16bfdcc View commit details
    Browse the repository at this point in the history

  4. Revert "make it android item with the packageIdentifier field in … 

    …`package.json`"

This reverts commit 4b320e9.
    @brodycj
    brodycj committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    ade785f View commit details
    Browse the repository at this point in the history

  5. change to simple androidPackageIdentifier item in package.json

    @brodycj
    brodycj committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    5d6c765 View commit details
    Browse the repository at this point in the history

  6. update test snapshots 

    (again)
    @brodycj
    brodycj committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    35ce549 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2020

  1. Merge branch 'master' of https://github.com/brodybits/create-react-na… 

    …tive-module into with-native-section
    @brodycj
    brodycj committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    6d97ab7 View commit details
    Browse the repository at this point in the history