Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move Android package ID from build.gradle to package.json #153

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions templates/android.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module.exports = platform => [{
name: () => `${platform}/build.gradle`,
content: ({ packageIdentifier }) => `// ${platform}/build.gradle
content: () => `// ${platform}/build.gradle

// based on:
//
Expand Down Expand Up @@ -84,7 +84,7 @@ def configureReactNativePom(def pom) {
name packageJson.title
artifactId packageJson.name
version = packageJson.version
group = "${packageIdentifier}"
group = packageJson.androidPackageIdentifier
description packageJson.description
url packageJson.repository.baseUrl

Expand Down
3 changes: 2 additions & 1 deletion templates/general.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ ${objectClassName};
`,
}, {
name: () => 'package.json',
content: ({ moduleName, platforms, githubAccount, authorName, authorEmail, license }) => {
content: ({ moduleName, packageIdentifier, platforms, githubAccount, authorName, authorEmail, license }) => {
const files =
`[
"README.md",` +
Expand Down Expand Up @@ -70,6 +70,7 @@ ${objectClassName};
"license": "${license}",
"licenseFilename": "LICENSE",
"readmeFilename": "README.md",
"androidPackageIdentifier": "${packageIdentifier}",
"peerDependencies": ${peerDependencies},
"devDependencies": ${devDependencies}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def configureReactNativePom(def pom) {
name packageJson.title
artifactId packageJson.name
version = packageJson.version
group = \\"com.reactlibrary\\"
group = packageJson.androidPackageIdentifier
description packageJson.description
url packageJson.repository.baseUrl

Expand Down Expand Up @@ -675,6 +675,7 @@ RCT_EXPORT_MODULE()
\\"license\\": \\"MIT\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def configureReactNativePom(def pom) {
name packageJson.title
artifactId packageJson.name
version = packageJson.version
group = \\"com.reactlibrary\\"
group = packageJson.androidPackageIdentifier
description packageJson.description
url packageJson.repository.baseUrl

Expand Down Expand Up @@ -670,6 +670,7 @@ RCT_EXPORT_METHOD(sampleMethod:(NSString *)stringArgument numberParameter:(nonnu
\\"license\\": \\"MIT\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ content:
\\"license\\": \\"MIT\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down Expand Up @@ -247,7 +248,7 @@ def configureReactNativePom(def pom) {
name packageJson.title
artifactId packageJson.name
version = packageJson.version
group = \\"com.reactlibrary\\"
group = packageJson.androidPackageIdentifier
description packageJson.description
url packageJson.repository.baseUrl

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ content:
\\"license\\": \\"MIT\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down Expand Up @@ -251,7 +252,7 @@ def configureReactNativePom(def pom) {
name packageJson.title
artifactId packageJson.name
version = packageJson.version
group = \\"com.reactlibrary\\"
group = packageJson.androidPackageIdentifier
description packageJson.description
url packageJson.repository.baseUrl

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ content:
\\"license\\": \\"ISC\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down Expand Up @@ -251,7 +252,7 @@ def configureReactNativePom(def pom) {
name packageJson.title
artifactId packageJson.name
version = packageJson.version
group = \\"com.reactlibrary\\"
group = packageJson.androidPackageIdentifier
description packageJson.description
url packageJson.repository.baseUrl

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ content:
\\"license\\": \\"ISC\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down Expand Up @@ -215,7 +216,7 @@ def configureReactNativePom(def pom) {
name packageJson.title
artifactId packageJson.name
version = packageJson.version
group = \\"com.reactlibrary\\"
group = packageJson.androidPackageIdentifier
description packageJson.description
url packageJson.repository.baseUrl

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ content:
\\"license\\": \\"ISC\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ content:
\\"license\\": \\"MIT\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down Expand Up @@ -247,7 +248,7 @@ def configureReactNativePom(def pom) {
name packageJson.title
artifactId packageJson.name
version = packageJson.version
group = \\"com.reactlibrary\\"
group = packageJson.androidPackageIdentifier
description packageJson.description
url packageJson.repository.baseUrl

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ content:
\\"license\\": \\"MIT\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ content:
\\"license\\": \\"MIT\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ content:
\\"license\\": \\"MIT\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ content:
\\"license\\": \\"MIT\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down Expand Up @@ -219,7 +220,7 @@ def configureReactNativePom(def pom) {
name packageJson.title
artifactId packageJson.name
version = packageJson.version
group = \\"com.reactlibrary\\"
group = packageJson.androidPackageIdentifier
description packageJson.description
url packageJson.repository.baseUrl

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ content:
\\"license\\": \\"MIT\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down Expand Up @@ -251,7 +252,7 @@ def configureReactNativePom(def pom) {
name packageJson.title
artifactId packageJson.name
version = packageJson.version
group = \\"com.reactlibrary\\"
group = packageJson.androidPackageIdentifier
description packageJson.description
url packageJson.repository.baseUrl

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ content:
\\"license\\": \\"MIT\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down Expand Up @@ -251,7 +252,7 @@ def configureReactNativePom(def pom) {
name packageJson.title
artifactId packageJson.name
version = packageJson.version
group = \\"com.reactlibrary\\"
group = packageJson.androidPackageIdentifier
description packageJson.description
url packageJson.repository.baseUrl

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ content:
\\"license\\": \\"MIT\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down Expand Up @@ -251,7 +252,7 @@ def configureReactNativePom(def pom) {
name packageJson.title
artifactId packageJson.name
version = packageJson.version
group = \\"com.reactlibrary\\"
group = packageJson.androidPackageIdentifier
description packageJson.description
url packageJson.repository.baseUrl

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ content:
\\"license\\": \\"ISC\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down Expand Up @@ -251,7 +252,7 @@ def configureReactNativePom(def pom) {
name packageJson.title
artifactId packageJson.name
version = packageJson.version
group = \\"com.reactlibrary\\"
group = packageJson.androidPackageIdentifier
description packageJson.description
url packageJson.repository.baseUrl

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ content:
\\"license\\": \\"MIT\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down Expand Up @@ -247,7 +248,7 @@ def configureReactNativePom(def pom) {
name packageJson.title
artifactId packageJson.name
version = packageJson.version
group = \\"com.reactlibrary\\"
group = packageJson.androidPackageIdentifier
description packageJson.description
url packageJson.repository.baseUrl

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ content:
\\"license\\": \\"ISC\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.alicebits\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down Expand Up @@ -215,7 +216,7 @@ def configureReactNativePom(def pom) {
name packageJson.title
artifactId packageJson.name
version = packageJson.version
group = \\"com.alicebits\\"
group = packageJson.androidPackageIdentifier
description packageJson.description
url packageJson.repository.baseUrl

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ content:
\\"license\\": \\"ISC\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ content:
\\"license\\": \\"ISC\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down Expand Up @@ -247,7 +248,7 @@ def configureReactNativePom(def pom) {
name packageJson.title
artifactId packageJson.name
version = packageJson.version
group = \\"com.reactlibrary\\"
group = packageJson.androidPackageIdentifier
description packageJson.description
url packageJson.repository.baseUrl

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ content:
\\"license\\": \\"ISC\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down Expand Up @@ -247,7 +248,7 @@ def configureReactNativePom(def pom) {
name packageJson.title
artifactId packageJson.name
version = packageJson.version
group = \\"com.reactlibrary\\"
group = packageJson.androidPackageIdentifier
description packageJson.description
url packageJson.repository.baseUrl

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ content:
\\"license\\": \\"MIT\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down Expand Up @@ -247,7 +248,7 @@ def configureReactNativePom(def pom) {
name packageJson.title
artifactId packageJson.name
version = packageJson.version
group = \\"com.reactlibrary\\"
group = packageJson.androidPackageIdentifier
description packageJson.description
url packageJson.repository.baseUrl

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ content:
\\"license\\": \\"MIT\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down Expand Up @@ -247,7 +248,7 @@ def configureReactNativePom(def pom) {
name packageJson.title
artifactId packageJson.name
version = packageJson.version
group = \\"com.reactlibrary\\"
group = packageJson.androidPackageIdentifier
description packageJson.description
url packageJson.repository.baseUrl

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ AliceBobbi;
\\"license\\": \\"MIT\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ AliceBobbi;
\\"license\\": \\"MIT\\",
\\"licenseFilename\\": \\"LICENSE\\",
\\"readmeFilename\\": \\"README.md\\",
\\"androidPackageIdentifier\\": \\"com.reactlibrary\\",
\\"peerDependencies\\": {
\\"react\\": \\"^16.8.1\\",
\\"react-native\\": \\">=0.60.0-rc.0 <1.0.x\\"
Expand Down
Loading