-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix brazilian portuguese translations #2803
Conversation
ad4185c
to
62a8958
Compare
Consider adding $ make
mkdir -p usr/share/locale/pt_BR/LC_MESSAGES
msgfmt -f --check-format pt_BR.po -o usr/share/locale/pt_BR/LC_MESSAGES/ubuntu-pro.mo
pt_BR.po:204: number of format specifications in 'msgid' and 'msgstr' does not match
pt_BR.po:214: number of format specifications in 'msgid' and 'msgstr' does not match
pt_BR.po:1319: a format specification for argument 'date' doesn't exist in 'msgstr'
msgfmt: found 3 fatal errors
make: *** [Makefile:8: pt_BR.mo] Error 1 |
6b19ff2
to
aa47fc7
Compare
@panlinux I have applied the suggestion to the Makefile command |
aa47fc7
to
465961b
Compare
@@ -493,7 +490,7 @@ msgstr[1] "" | |||
"Renove sua assinatura em {url}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ubuntu Pro
is lowercase in the translation, but Ubuntu Pro
in the original text. Also, wasn't this translation meant to support singular and plural texts? Just wondering because both in the original string and in the translated one, it's plural (or at least using (s)
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, sorry, just saw it now, but the translated string is using PRO
instead of Pro
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I have solved the issue
Some brazilian portuguese translations are marked as fuzzy. We are removing the tag from the ones we believe are correct
This flag will allow us to more easily catch possible mismatched translations on the po files
739a4f0
to
60b9eba
Compare
We need to increase the width of the status column to better address the column placement when the portuguese translations are used. Note that this is a temporary solution, as we should dynamically compute those column values.
60b9eba
to
b131c08
Compare
@@ -2554,7 +2557,7 @@ msgstr "" | |||
|
|||
#: ../../uaclient/messages/__init__.py:1463 | |||
msgid "All Updates for the Robot Operating System" | |||
msgstr "" | |||
msgstr "Todas as Atualizações para o Robot Operating System" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Atualizações/atualizações
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept the uppercase to match the uppercase in All Updates.
I think we must have a policy for this, because it is not consistent across messages
Signed-off-by: Renan Rodrigo <[email protected]>
c5c06f8
to
eb00954
Compare
Why is this needed?
Some brazilian portuguese translations are incorrect. This PR fix those issues
Test Steps
Check the modified translation matches the english string
Checklist
Does this PR require extra reviews?