Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ewellix Lift #136

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Ewellix Lift #136

merged 1 commit into from
Jan 14, 2025

Conversation

luis-camero
Copy link
Contributor

Add Ewellix description.

JointTrajectoryController not yet implemented in the hardware interface. Currently, the JTC configuration files can be swapped for the default (JointGroupPositionController) to move the lift using MoveIt in simulation.

Depends on: clearpathrobotics/clearpath_config#109

@luis-camero luis-camero requested a review from a team as a code owner December 20, 2024 13:19
@luis-camero luis-camero requested review from mhosmar-cpr and civerachb-cpr and removed request for a team December 20, 2024 13:19
@luis-camero luis-camero changed the title Feature/ewellix Ewellix Lift Dec 20, 2024
Copy link
Contributor

@civerachb-cpr civerachb-cpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I have no way of testing this, but I assume that's been done on an integration project already?

Once this is merged can you please make an MR to cherry-pick it into Jazzy, along with the necessary Jazzy linting changes?

    Add moveit jpc

    Add control for joint position controller

    Add hardware parameters

    Add lifts to generators

    Initial add of Ewellix lift description files
@luis-camero luis-camero merged commit 5a0f7dc into rc/humble-1.1 Jan 14, 2025
1 of 9 checks passed
luis-camero added a commit that referenced this pull request Jan 17, 2025
Ewellix Lift
-  Remove upper_joint   
- Add moveit jpc
- Add control for joint position controller
- Add hardware parameters
- Add lifts to generators
- Initial add of Ewellix lift description files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants