Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zenoh support #113

Merged
merged 9 commits into from
Jan 16, 2025
Merged

Add Zenoh support #113

merged 9 commits into from
Jan 16, 2025

Conversation

civerachb-cpr
Copy link
Contributor

No description provided.

@civerachb-cpr civerachb-cpr requested a review from a team as a code owner January 15, 2025 16:47
@civerachb-cpr civerachb-cpr requested review from mhosmar-cpr and luis-camero and removed request for a team January 15, 2025 16:47
@tonybaltovski
Copy link
Member

@civerachb-cpr can we add per platform support for this?

@tonybaltovski tonybaltovski changed the base branch from jazzy-2.0RC to rc/jazzy-2.1 January 15, 2025 16:58
@civerachb-cpr
Copy link
Contributor Author

@civerachb-cpr can we add per platform support for this?

Not super easily, no. There's currently nothing in the code that checks for platform/middleware validation, as I don't think we ever anticipated we'd have situations where we can't support something on all platforms.

It's doable, but isn't going to be a trivial change.

Since we've already merged the other Zenoh-related MRs, do we want to continue with this one as-is, or make the needed changes to prevent Zenoh from being used on A300 right now?

@civerachb-cpr
Copy link
Contributor Author

@tonybaltovski I've just pushed some changes to prevent trying to use Zenoh on the A300 (or indeed anything except A200)

Copy link
Collaborator

@luis-camero luis-camero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current framework, this is the most appropriate way to handle this middleware requirement. The RPSW-2369 ticket covers this issue and how a rework would allow us to define supported accessories/tools for each platform.

@luis-camero
Copy link
Collaborator

This needs to get merged in Jazzy 2.0. The zenoh generator has already been merged.

@luis-camero luis-camero changed the base branch from rc/jazzy-2.1 to jazzy January 16, 2025 20:01
@civerachb-cpr civerachb-cpr merged commit d0d3e72 into jazzy Jan 16, 2025
6 checks passed
@civerachb-cpr civerachb-cpr deleted the zenoh branch January 16, 2025 20:11
@tonybaltovski
Copy link
Member

Thanks @civerachb-cpr !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants