-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zenoh support #113
Add Zenoh support #113
Conversation
…, as that's what it's for
@civerachb-cpr can we add per platform support for this? |
Not super easily, no. There's currently nothing in the code that checks for platform/middleware validation, as I don't think we ever anticipated we'd have situations where we can't support something on all platforms. It's doable, but isn't going to be a trivial change. Since we've already merged the other Zenoh-related MRs, do we want to continue with this one as-is, or make the needed changes to prevent Zenoh from being used on A300 right now? |
…croROS-using platform
@tonybaltovski I've just pushed some changes to prevent trying to use Zenoh on the A300 (or indeed anything except A200) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the current framework, this is the most appropriate way to handle this middleware requirement. The RPSW-2369 ticket covers this issue and how a rework would allow us to define supported accessories/tools for each platform.
This needs to get merged in Jazzy 2.0. The zenoh generator has already been merged. |
Thanks @civerachb-cpr !!! |
No description provided.