Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Duck Player copy #4931

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Aug 23, 2024

Task/Issue URL: https://app.asana.com/0/1205008441501016/1208132429682162/f

Description

Translations + remove description from Duck Player settings dialog

Steps to test this PR

Feature 1

  • [ ]
  • [ ]

UI changes

settings

Copy link
Contributor Author

CrisBarreiro commented Aug 23, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CrisBarreiro and the rest of your teammates on Graphite Graphite

@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/ship-review-l10n branch 5 times, most recently from 6e7fcf4 to 6f49957 Compare August 23, 2024 12:04
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duckplayer/create-module branch from 801ccdb to bce739b Compare August 26, 2024 10:36
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/ship-review-l10n branch from 2e10d33 to 155d145 Compare August 26, 2024 10:36
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duckplayer/create-module branch from bce739b to a3c0319 Compare August 26, 2024 16:18
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/ship-review-l10n branch from 73036e9 to 5f361b4 Compare August 26, 2024 16:19
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duckplayer/create-module branch from a3c0319 to c5fd6cd Compare August 27, 2024 11:12
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/ship-review-l10n branch from 1f41f28 to a321fc0 Compare August 27, 2024 11:12
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duckplayer/create-module branch from c5fd6cd to 5a430ad Compare August 27, 2024 11:14
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/ship-review-l10n branch 2 times, most recently from 2e43c90 to 3e65aa8 Compare August 27, 2024 14:47
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duckplayer/create-module branch from 486c20c to 9964f16 Compare August 28, 2024 08:16
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/duck-player/ship-review-l10n branch from 3e65aa8 to 2424959 Compare August 28, 2024 08:31
Translate strings-duckplayer to values-fi
Translate strings-duckplayer to values-pl
Translate strings-duckplayer to values-sl
Translate strings-duckplayer to values-da
Translate strings-duckplayer to values-de
Translate strings-duckplayer to values-it
Translate strings-duckplayer to values-es
Translate strings-duckplayer to values-lt
Translate strings-duckplayer to values-et
Translate strings-duckplayer to values-sv
Translate strings-duckplayer to values-tr
Translate strings-duckplayer to values-pt
Translate strings-duckplayer to values-lv
Translate strings-duckplayer to values-hu
Translate strings-duckplayer to values-fr
Translate strings-duckplayer to values-hr
Translate strings-duckplayer to values-ru
Translate strings-duckplayer to values-nb
Translate strings-duckplayer to values-sk
Translate strings-duckplayer to values-bg
Translate strings-duckplayer to values-ro
Translate strings-duckplayer to values-cs
Translate strings-duckplayer to values-nl
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrisBarreiro CrisBarreiro merged commit 74a6490 into feature/cris/duckplayer/create-module Aug 28, 2024
5 of 6 checks passed
@CrisBarreiro CrisBarreiro deleted the feature/cris/duck-player/ship-review-l10n branch August 28, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants