github-action: support check/lint/pre-commit

.github/workflows/check-deploy-kubernetes.yml

@@ -0,0 +1,29 @@
+name: check-deploy-kubernetes
+
+on:
+  pull_request:
+    paths:
+      - "deploy/kubernetes/.*"
+      - "libbeat/docs/version.asciidoc"
+      - ".github/workflows/check-deploy-kubernetes.yml"
+  push:
+    branches:
+      - main
+      - 7.1*
+      - 8.*
+
+permissions:
+  contents: read
+
+jobs:
+  check:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+    - uses: actions/setup-go@v4
+      with:
+        go-version-file: .go-version
+    - name: Run deploy/kubernetes all
+      run: make -C deploy/kubernetes all
+    - name: Run check-no-changes
+      run: make check-no-changes

.github/workflows/pre-commit.yml

@@ -0,0 +1,19 @@
+name: pre-commit
+
+on:
+  # TODO: skip if doc changes only (.*\\.(asciidoc|md)|deploy/kubernetes/.*-kubernetes\\.yaml)
+  pull_request:
+  push:
+    branches:
+      - main
+      - 7.1*
+      - 8.*
+
+permissions:
+  contents: read
+
+jobs:
+  pre-commit:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: elastic/apm-pipeline-library/.github/actions/pre-commit@current

.pre-commit-config.yaml

@@ -3,10 +3,3 @@ repos:
     rev: v4.4.0
     hooks:
     -   id: check-merge-conflict
-
--   repo: https://github.com/elastic/apm-pipeline-library.git
-    rev: v1.1.397
-    hooks:
-    -   id: check-jenkins-pipelines
-        files: ^(.ci/(.*\.groovy|Jenkinsfile)|Jenkinsfile)$
-    -   id: check-jjbb

Jenkinsfile

@@ -80,28 +80,6 @@ pipeline {
         }
       }
     }
-    stage('Checks'){
-      options { skipDefaultCheckout() }
-      environment {
-        GOFLAGS = '-mod=readonly'
-      }
-      steps {
-        withGithubNotify(context: "Checks") {
-          stageStatusCache(id: 'Checks'){
-            // test the ./dev-tools/run_with_go_ver used by the Unified Release process
-            dir("${BASE_DIR}") {
-              sh "HOME=${WORKSPACE} GO_VERSION=${GO_VERSION} ./dev-tools/run_with_go_ver make test-mage"
-            }
-            withBeatsEnv(archive: false, id: "checks") {
-              dumpVariables()
-              whenTrue(env.ONLY_DOCS == 'false') {
-                runChecks()
-              }
-            }
-          }
-        }
-      }
-    }
     stage('Build&Test') {
       options { skipDefaultCheckout() }
       when {
@@ -218,29 +196,6 @@ def isGitHubIssueEnabled() {
   return isBranch() && currentBuild.currentResult != "SUCCESS" && currentBuild.currentResult != "ABORTED"
 }
 
-def runChecks() {
-  def mapParallelTasks = [:]
-  def content = readYaml(file: 'Jenkinsfile.yml')
-  content['projects'].each { projectName ->
-    generateStages(project: projectName, changeset: content['changeset'], filterStage: 'checks').each { k,v ->
-      mapParallelTasks["${k}"] = v
-    }
-  }
-  // Run pre-commit within the current node and in Jenkins
-  // hence there is no need to use docker login in the GitHub actions
-  // some docker images are hosted in an internal docker registry.
-  mapParallelTasks['pre-commit'] = runPreCommit()
-  parallel(mapParallelTasks)
-}
-
-def runPreCommit() {
-  return {
-    withGithubNotify(context: 'Check pre-commit', tab: 'tests') {
-      preCommit(commit: "${GIT_BASE_COMMIT}", junit: true)
-    }
-  }
-}
-
 def runBuildAndTest(Map args = [:]) {
   def filterStage = args.get('filterStage', 'mandatory')
   deleteDir()

deploy/kubernetes/Jenkinsfile.yml

@@ -12,11 +12,6 @@ when:
     tags: true                 ## for all the tags
 platform: "immutable && ubuntu-22" ## default label for all the stages
 stages:
-    checks:
-        make: |
-            make -C deploy/kubernetes all;
-            make check-no-changes;
-        stage: checks
     k8sTest:
         k8sTest: "v1.29.0,v1.28.0,v1.27.3,v1.26.6"
         stage: mandatory