-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github-action: support check/lint/pre-commit #38175
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8880d60
github-action: support check/lint
v1v 242691b
github-action: enable precommit
v1v e2b8d36
remove unrequired steps
v1v b502de3
test
v1v 786a42c
DRA
v1v 4e42dc7
if changes in the workflow
v1v 5df2fe0
fix regex
v1v 7a8d2f3
Update .github/workflows/pre-commit.yml
v1v 45c430d
Merge branch 'main' into feature/check-on-gh-actions
v1v 2505ea4
keep previous setup
v1v d243bf9
Update Jenkinsfile
v1v 0b74c3b
Update Jenkinsfile
v1v a9e6951
Merge branch 'main' into feature/check-on-gh-actions
v1v File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
name: pre-commit | ||
|
||
on: | ||
pull_request: | ||
push: | ||
branches: | ||
- main | ||
- 7.1* | ||
- 8.* | ||
|
||
permissions: | ||
contents: read | ||
|
||
jobs: | ||
pre-commit: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: elastic/apm-pipeline-library/.github/actions/pre-commit@current |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,10 +3,3 @@ repos: | |
rev: v4.4.0 | ||
hooks: | ||
- id: check-merge-conflict | ||
|
||
- repo: https://github.com/elastic/apm-pipeline-library.git | ||
Comment on lines
-6
to
-7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is no need to support this |
||
rev: v1.1.397 | ||
hooks: | ||
- id: check-jenkins-pipelines | ||
files: ^(.ci/(.*\.groovy|Jenkinsfile)|Jenkinsfile)$ | ||
- id: check-jjbb |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are moving to BK, I would like to ask if we can split this PR into two smaller ones, one containing only the changes to the
.pre-commit-config.yaml
and then a follow-up to either try adding it to BK or, if that fails then the GH workflow.