Skip to content

Standup Notes 2020 02 11

Jump to bottom
Erik Moeller edited this page Feb 12, 2020 · 1 revision

Participants (alphabetical): Allie, Conor, Erik, Jen, John, Kevin, Kushal, Mickael, Nina, Ro

Topics and Call-outs

Allie

Yesterday:

Today:

  • Rebased #786 to fix CI issue found last night, ready for review
  • Work on architecture doc updates
  • Re-review John's PR and verify that https://github.com/freedomofpress/securedrop-client/issues/754 is fixed
  • Re-review Nick's PR for "Last refresh" and verify that the last refresh time doesn't show up when logged in and that it appears right away when logged out and that there's no other funny business
  • Try to repro #717 (if it can't be repo'd anymore, figure out when it was fixed)
  • If there is time, work on CUPS enabled bug

Blockers or Asks: None

Conor

Yesterday:

Today:

Blockers or Asks:

Erik

Yesterday:

  • Begin addressing review comments on #445; handle file permissions in RPM packaging as part of same PR
  • README cleanup, small workstation docs PR

Today:

  • Finish addressing review comments on #445
  • More docs work
  • Backlog/release blocker review

Blockers or Asks: None

Jen

Yesterday:

  • took a look at functional tests that nick was workin on
  • did the large file testing in staging workstation environment, seems to be workin well (tor is slow but that's not news), investigated the KeyError kushal experienced which should be fixed on master of securedrop-sdk

Today:

  • master of sdk ci failing due to something pip(?) related, investigatin and will fix in my PR adding a regression test for the above KeyError issue THEN ima do a release so we can use these fixes in the client.. this might stretch into tomorrow
  • reviews that go onto my plate: refactor queue from allie, gpg key from john

Blockers or Asks:

  • none

John

Yesterday:

Today:

Blockers or Asks:

  • None

Kev

Yesterday:

  • #402 -- updater fix to not run updater when it doesn't need to Today:
  • Cont'd on ^^
  • Back to #5110

Blockers or Asks: Coordination with Conor on above as needed

Kushal

Today:

Tomorrow:

  • Finish off tests for #447

Blockers or Asks: None

Mickael

Yesterday:

Blockers or Asks:

Nicholas

  • Today: *
    • Created PR #792 to fix flicker on mouse-over in download button.
    • Responded to various bits of feedback on my in-flight PRs.
    • Fixed PR #790 in light of Allie's feedback (thanks!). Help needed: clarification on what's meant by "timestamp". Thanks!
    • Continued to work on #788 (adding functional tests). Thanks Jen for the feedback and I've made (local) changes. Found a nasty bug relating to the qtbot (which interacts with the widgets we're testing) but coded around it by removing a single line. Discussed mocking strategy in a quick call with Jen earlier this afternoon. I'll continue with this work tomorrow. My aim is to have scaffolding and example tests ready for review.

*Blockers or Asks: *

  • None.

Nina

Yesterday:

  • Debugging SVG issues with login screen, fixed by trial & error :/

Today:

  • Check-in on priorities Blockers or Asks:

Ro

Yesterday:

  • Misc. support comms

Today:

  • ^^
  • Reviewed workstation docs PR, self-assigned other docs issues

Blockers or Asks: None

Clone this wiki locally