Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [service] systemd service rename. #1970

Merged
merged 3 commits into from
May 9, 2024

Conversation

itsXuSt
Copy link
Contributor

@itsXuSt itsXuSt commented May 6, 2024

rename dde-filemanager-server.service to dde-file-manager.service, to
make the new AM know it's belongs to dde-file-manager, so that dfm
launched by FileManager1::showFolder have a correct icon on dock.

Log: adapt the new Application Manager.

@deepin-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Johnson-zs
Johnson-zs previously approved these changes May 7, 2024
rename dde-filemanager-server.service to dde-file-manager.service, to
make the new AM know it's belongs to dde-file-manager, so that dfm
launched by FileManager1::showFolder have a correct icon on dock.

Log: adapt the new Application Manager.
open computer:/// trash:/// with xdg-open on V23, and gio open on UOS.

Log: as title.
Johnson-zs
Johnson-zs previously approved these changes May 7, 2024
@Zeno-sole
Copy link
Contributor

/intergrate

@Zeno-sole
Copy link
Contributor

/integrate

Copy link

github-actions bot commented May 7, 2024

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#1385
PrNumber: 1385
PrBranch: auto-integration-8981776149

as title.

Log: version update.
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码中的文件打开命令使用了 gio openxdg-open,建议统一使用一种以保持一致性。
  • 修改了 D-BUS 服务的名称,从 dde-filemanager-server 改为 dde-file-manager,需要确保这一改动不会影响其他依赖此服务的组件。

是否建议立即修改:

  • 是,建议立即统一文件打开命令的实现方式,并验证和验证更改后的 D-BUS 服务名称是否不会引起其他问题。

@Zeno-sole
Copy link
Contributor

/integrate

Copy link

github-actions bot commented May 7, 2024

TAG Bot

TAG: 6.0.50
EXISTED: no
DISTRIBUTION: unstable

@Zeno-sole
Copy link
Contributor

/topic cd-0507

@deepin-ci-robot
Copy link

Add topic: cd-0507 successed.

@Zeno-sole
Copy link
Contributor

/integr-topic cd-0507

@deepin-ci-robot
Copy link

Alreadly latest topic integration with deepin-community/Repository-Integration#1386

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itsXuSt, Johnson-zs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@itsXuSt
Copy link
Contributor Author

itsXuSt commented May 9, 2024

/merge

@deepin-bot deepin-bot bot merged commit b22215d into linuxdeepin:master May 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants