Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control over general Velero Backup/Restore Spec that gets exposed or allow listed via NAB/NAR CRD spec. #37

Open
shubham-pampattiwar opened this issue Apr 9, 2024 · 3 comments
Assignees

Comments

@shubham-pampattiwar
Copy link
Member

shubham-pampattiwar commented Apr 9, 2024

The Velero Backup CR/Restore CR consists of a plethora of Backup/Restore Spec options. It might be desirable to have a control over the spec that is exposed or may be allowlisted for non-admin users.

  • For instance, Backup Spec IncludedNamespaces should by default be the non-admin user's namespace as this is a scoped backup operation
  • Another instance is mentioned in the relevant discussion of cluster admins wanting to set a default backup TTL for all the non-admin users
  • Or maybe the cluster-admins want to enforce that only fs-backups should be used for volumes, so defaultVolumesToFSBackup should be true for all non-admin backups
@weshayutin weshayutin moved this to New / Design in OADP Apr 9, 2024
@shubham-pampattiwar
Copy link
Member Author

Might need some design, current approach of accepting values from cm is added in main deisgn

@weshayutin weshayutin moved this from New / Design to Todo in OADP Apr 9, 2024
@mateusoliveira43 mateusoliveira43 moved this from Todo to In Progress in OADP Apr 15, 2024
@mateusoliveira43
Copy link
Contributor

As mentioned in #35, this also needs to apply to Restore specs

@shubham-pampattiwar can you please update issue title to reflect this (or better to have one issue per object?)

@shubham-pampattiwar shubham-pampattiwar changed the title Control over general Velero Backup Spec that gets exposed or allow listed via NAB CRD spec. Control over general Velero Backup/Restore Spec that gets exposed or allow listed via NAB/NAR CRD spec. Apr 17, 2024
@shubham-pampattiwar
Copy link
Member Author

@mateusoliveira43 Done, updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

2 participants