Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added joint limits to rviz launch file. #3091

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

m-elwin
Copy link
Contributor

@m-elwin m-elwin commented Nov 14, 2024

Rviz now loads the moveit joint limits, enabling cartesian planning from rviz.

Description

Addresses issue #2989 by having the rviz generator use the joint limits provided by the MoveItConfigsBuilder.
Currently, these joint limits are not added as parameters to rviz, which can break behavior such as cartesian path planning.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Rviz now loads the moveit joint limits, enabling cartesian planning from rviz.
@sea-bass sea-bass added this pull request to the merge queue Nov 15, 2024
Merged via the queue into moveit:main with commit 0f4c935 Nov 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants