-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK: abstracted and minimal nuclei v3 sdk #4104
Conversation
View SDK docscd v2/lib
godoc -http=:6060 ^ this will start a local doc server with final docs which includes testable examples at http://localhost:6060/pkg/github.com/projectdiscovery/nuclei/v2/lib/ |
New Changes
New /metrics endpoint{
"requests": 3416,
"errors": 955,
"matched": 15,
"startedAt": "2023-08-30T19:02:13.636473+05:30",
"summary": "[0:00:27] | Templates: 6720 | Hosts: 1 | RPS: 126 | Matched: 15 | Errors: 955 | Requests: 3416/9963 (34%)\n",
"rps": "126",
"total": 9963,
"templates": 6720,
"hosts": 1,
"duration": "0:00:27",
"percent": "34"
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - nice one! This was really a must-do. The absence of consistent components initializations with reasonable defaults along with a too long boilerplate to just create an instance was definitely a usability anti-pattern.
Proposed changes
nuclei/v2/lib/README.md
Lines 1 to 87 in 186a4da
Design Considerations
Option Style
syntax to abstract options (we have so many options in nuclei >30 this style of syntax i.e option style is more powerful and suitable for such cases)Checklist