Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

target/sim: Add external serial link AXI port to VIP #51

Merged
merged 6 commits into from
Jul 20, 2023
Merged

target/sim: Add external serial link AXI port to VIP #51

merged 6 commits into from
Jul 20, 2023

Conversation

alex96295
Copy link
Collaborator

@alex96295 alex96295 commented Jul 7, 2023 •
edited
Loading

In the vip, add mutiple virtual AXI drivers to drive the serial link

@alex96295 alex96295 marked this pull request as ready for review July 7, 2023 15:18
micprog
micprog requested changes Jul 8, 2023
View reviewed changes
Copy link
Member

@micprog micprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if I understood this wrong or if this was the goal, happy to discuss in person as well.

target/sim/src/fixture_cheshire_soc.sv Outdated Show resolved Hide resolved
target/sim/src/vip_cheshire_soc.sv Outdated Show resolved Hide resolved
@alex96295 alex96295 marked this pull request as draft July 10, 2023 12:49
@alex96295 alex96295 changed the title target/sim/src: Demultiplex virtual AXI driver to bypass Serial Link target/sim/src: Multiplex virtual AXI driver to Serial Link Jul 10, 2023
@alex96295 alex96295 force-pushed the aottaviano/vip branch 3 times, most recently from e769572 to d54caaf Compare July 11, 2023 06:47
micprog
micprog reviewed Jul 11, 2023
View reviewed changes
Copy link
Member

@micprog micprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the width change, I think this is what we discussed also with @paulsc96.

target/sim/src/vip_cheshire_soc.sv Outdated Show resolved Hide resolved
@alex96295 alex96295 marked this pull request as ready for review July 14, 2023 20:23
micprog
micprog previously approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@micprog micprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@paulsc96 paulsc96 changed the title target/sim/src: Multiplex virtual AXI driver to Serial Link target/sim: Add external serial link AXI port Jul 20, 2023
@paulsc96 paulsc96 changed the title target/sim: Add external serial link AXI port target/sim: Add external serial link AXI port to VIP Jul 20, 2023
paulsc96
paulsc96 approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@paulsc96 paulsc96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulsc96 paulsc96 merged commit 81fa6b6 into main Jul 20, 2023
9 of 10 checks passed
@paulsc96 paulsc96 deleted the aottaviano/vip branch July 20, 2023 18:39
MaistoV pushed a commit to MaistoV/cheshire_fork that referenced this pull request Aug 23, 2023
@alex96295 @micprog
@paulsc96 @MaistoV
target/sim: Add external serial link AXI port to VIP (pulp-platform#51)
2497dde 
* target/sim/src: Add 2x1 mux to allow external Serial Link drivers

* target/sim/src: Attempt to simplify external AXI mst

* target/sim/src: Remove axi_id_remap

* vip: Simplify external port connection

* clic: Fix connection parameterization

* Bender.yml: Update `axi` release

---------

Co-authored-by: Michael Rogenmoser <[email protected]>
Co-authored-by: Paul Scheffler <[email protected]>
Aquaticfuller pushed a commit that referenced this pull request Jul 16, 2024
@alex96295
Merge pull request #51 from pulp-platform/aottaviano/axi-rt
e9f737c 
Integrate AXI RT feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulsc96 paulsc96 paulsc96 approved these changes

@micprog micprog micprog left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex96295 @micprog @paulsc96