Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pip specific content contribution rosdep rules for Gentoo #29909

Merged
merged 4 commits into from
Jun 17, 2021
Merged

Conversation

tfoote
Copy link
Member

@tfoote tfoote commented Jun 15, 2021

Fixes: #29908

@allenh1 From your suggestion.

@tfoote tfoote requested review from mabelzhang and a team June 15, 2021 19:45
@allenh1
Copy link
Contributor

allenh1 commented Jun 15, 2021

lgtm

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor rewording changes.

.github/pull_request_template.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
tfoote and others added 2 commits June 15, 2021 14:41
Co-authored-by: Chris Lalancette <[email protected]>
@tfoote tfoote requested a review from clalancette June 15, 2021 21:42
CONTRIBUTING.md Outdated Show resolved Hide resolved
@mabelzhang
Copy link
Contributor

mabelzhang commented Jun 17, 2021

Did this PR also mean to add a note about pip in the REVIEW_GUIDELINES (line 63)? Maybe something like, for Gentoo entries, check that it does not use pip, and if it does, refer to CONTRIBUTING.

Related, but not to this PR, I did a search in rosdep/python.yaml and found that we do have like a dozen gentoo+pip entries, like https://github.com/ros/rosdistro/pull/29426/files . I don't know if we can/want to do anything about them.

@tfoote
Copy link
Member Author

tfoote commented Jun 17, 2021

Did this PR also mean to add a note about pip in the REVIEW_GUIDELINES (line 63)? Maybe something like, for Gentoo entries, check that it does not use pip, and if it does, refer to CONTRIBUTING.

I initially thought to do that. But then I realized that all the distro related rules are here in the CONTRIBUTING document and that these rules are directly linked in the REVIEWING section. There's several other rules per distro that are at the same level. This one is new but doesn't seem to have any distinction compared to all the others. And duplicating the requirements in a second location I think will lead to more maintenance or inconsistency in statements.

Related, but not to this PR, I did a search in rosdep/python.yaml and found that we do have like a dozen gentoo+pip entries, like https://github.com/ros/rosdistro/pull/29426/files . I don't know if we can/want to do anything about them.

A PR to clean them up/remove them would be great, it's mostly a matter of having the time to clean it up. We can definitely remove them as they're not expected to work and as such won't break people to remove them and we don't need a sunsetting process.

@mabelzhang
Copy link
Contributor

I could do that PR. But does that mean we also want to create ros/ros-overlay tickets for all of them?

@tfoote
Copy link
Member Author

tfoote commented Jun 17, 2021

I could do that PR. But does that mean we also want to create ros/ros-overlay tickets for all of them?

Great. Ticketing it over there too would be great. To be quicker maybe just a single ticket with each of the dependencies you cleared as a checkbox instead of opening a bunch of tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Gentoo CONTRIBUTING guides to clarify about pip rules
5 participants