Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pip specific content contribution rosdep rules for Gentoo #29909

Merged
merged 4 commits into from
Jun 17, 2021
Merged

Add pip specific content contribution rosdep rules for Gentoo #29909

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a06956
Add pip specific content for Gentoo
tfoote Jun 15, 2021
8873e2b
Update .github/pull_request_template.md
tfoote Jun 15, 2021
f95987c
Update CONTRIBUTING.md
tfoote Jun 15, 2021
e586be2
Update CONTRIBUTING.md
tfoote Jun 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ Distro packaging links:

## Links to Distribution Packages

<!-- Replace the REQUIRED areas and state not available for IF AVAILABLE -->
<!-- Replace the REQUIRED areas and state not available for IF AVAILABLE
tfoote marked this conversation as resolved.
Show resolved Hide resolved
More info at https://github.com/ros/rosdistro/blob/master/CONTRIBUTING.md#guidelines-for-rosdep-rules -->

- Debian: https://packages.debian.org/
- REQUIRED
Expand Down
6 changes: 6 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,9 @@ TODO
If the ebuild you are referencing is not in either of those locations, please
file a PR into ROS-Overlay to add it and any needed dependencies to the tree.

Note that `pip` cannot be used to install system packages on Gentoo.
If the package is not present in the Gentoo package repository, please create an issue on the ros/ros-overlay repository so that it may be created at a later date, omit the key from the new rosdep rule, and link the created issue in the PR which is adding the rule.
tfoote marked this conversation as resolved.
Show resolved Hide resolved

#### Arch Linux

Packages must be in the official Archlinux core, extra, or community repositories at the time they are contributed.
Expand Down Expand Up @@ -216,6 +219,9 @@ Some existing rules do not have `python-` or `python3-` prefixes, but this is no
If the package ever becomes available in Debian or Ubuntu, the `python3-` prefix ensures that the `pip` key is next to it alphabetically.
The `-pip` key should be removed when the package becomes available on all platforms, and all existing users of the `-pip` key should migrate to the new key.

As a reminder `pip` rules should not be used on Gentoo.
See above for the Gentoo specific guidelines.

How to submit pull requests
---------------------------

Expand Down