-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document package tarballs #646
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ccfb43
to
e19cde3
Compare
12caeff
to
76b6c95
Compare
16d5717
to
62afa60
Compare
62afa60
to
372a81e
Compare
Merged
372a81e
to
2ffc1aa
Compare
This was referenced Sep 25, 2023
2ffc1aa
to
0b4554f
Compare
0b4554f
to
d43aac6
Compare
d43aac6
to
e900f03
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
1. There were no reasons to disallow `[[target.lib]]`. 2. On the other hand, it would be cool to expect target names to have package-name-style validation. --- **Stack**: - #697 - #710 - #675 - #657 - #646 - #712 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
a25f452
to
b21e68c
Compare
commit-id:87f8c915
b21e68c
to
8fa5880
Compare
szymmis
approved these changes
Sep 28, 2023
maciektr
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
scarb package
command, implementing--list
arg #657