Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TomlTargetKind parsing rules #708

Closed
wants to merge 2 commits into from
Closed

Fix TomlTargetKind parsing rules #708

wants to merge 2 commits into from

Conversation

mkaput
Copy link
Member

@mkaput mkaput commented Sep 25, 2023 •
edited
Loading

  1. There were no reasons to disallow [[target.lib]].
  2. On the other hand, it would be cool to expect target names to be valid package names.

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@mkaput
Use UTF-8 paths for source-path field
f06e311 
commit-id:09ea1b37
@mkaput
Fix TomlTargetKind parsing rules
19c4ed0 
1. There were no reasons to disallow `[[target.lib]]`.
2. On the other hand, it would be cool to expect target names to be valid package names.

commit-id:d245029f
This was referenced Sep 25, 2023
Closed
Merged
Merged
Merged
Merged
Merged
@mkaput mkaput requested a review from maciektr September 25, 2023 19:42
@mkaput
Copy link
Member Author

mkaput commented Sep 25, 2023

Closing pull request: commit has gone away

@mkaput mkaput closed this Sep 25, 2023
@mkaput mkaput reopened this Sep 25, 2023
Base automatically changed from spr/main/09ea1b37 to main September 26, 2023 05:16
github-merge-queue bot pushed a commit that referenced this pull request Sep 26, 2023
@mkaput
Use UTF-8 paths for source-path field (#707)
66baac7 
**Stack**:
- #709
- #697
- #675
- #657
- #646
- #708
- #707 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@mkaput
Copy link
Member Author

mkaput commented Sep 26, 2023

superseded by #712

@mkaput mkaput closed this Sep 26, 2023
@mkaput mkaput deleted the spr/main/d245029f branch September 27, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciektr maciektr Awaiting requested review from maciektr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mkaput