update merge master #18

tarawow · 2024-10-04T03:48:09Z

Changes Proposed:

This PR proposes changes to:

Core (units, players, creatures, game systems).
Scripts (bosses, spell scripts, creature scripts).
Database (SAI, creatures, etc).

Issues Addressed:

Closes

SOURCE:

The changes have been validated through:

Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
Sniffs (remember to share them with the open source community!)
Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

Tested in-game by the author.
Tested in-game by other community members/someone else other than the author/has been live on production servers.
This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

This pull request can be tested by following the reproduction steps provided in the linked issue
This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

[ ]
[ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

Updating Alterac

…19884) titan's grip, unequip with full bags

#19927)

…#19947) fix(Scripts/BlackTemple): Fix variable not being set to false when Akama dies

…of Azzinoth (#19967) fix(Scripts/Core): fix blaze and flame bast casting for Flame of Azzinoth

…#19948) * fix(Scripts/BlackTemple): fix stationary shadow demons * optimization: use else if to stop the execution when a condition is reach * revert last changes and fix the spell to allow move while casting * .

#19944) * fix(Scripts/BlackTemple): Parasitic Shadowfiends should not target players affected with debuff * Update boss_illidan.cpp * Update src/server/scripts/Outland/BlackTemple/boss_illidan.cpp * make it simple

#19946) * fix(Scripts/BlackTemple): Implement emotes when opening Najentus and Den of Mortal Delights * only check if state is done

Referenced commit(s): 8b16f7d

* fix(Scripts/BT): correct illidari council enrage timer * wrong conversion from 5ae1473 * redundant

…19969)

#19962) * fix(Core/PlayerQuest): Introduce flag QUEST_SPECIAL_FLAGS_NO_LOREMASTER_COUNT - this allows flagging quests so that they will not count towards Loremaster achievement - update Corrupted Flower Quests in Felwood accordingly as a first use case * load Specialflags as uint32 from DB

Referenced commit(s): e2353a1

Revert "fix(Core/Spells): Resolve a case of triggered spells prolonging comba…" This reverts commit edd7e10.

Init.

Referenced commit(s): 07c54fe

…19968) fix(Scripts/BlackTemple): fix the charge mechanic of Flames of Azzinoth * remove also a old duplicate check in a spell script

#19451)

…t. (#19991) * Revert "fix(Core/Spells): Revert triggered spell logic change. (#19983)" This reverts commit 3bb5ec7. * Add aura effect check. Co-Authored-By: Anton Popovichenko <[email protected]> * Add comment, use target instead of owner. * Adjust comment terminology. --------- Co-authored-by: Anton Popovichenko <[email protected]>

Try to fix bug with loot

…ng (#19957) * fix(DB/Creature) Black Temple - Illidari Assassin: Riposte ability missing * fix(DB/Creature): Black Temple - Illidari Assassin: Riposte ability missing * Update 2024_09_13_00.sql * bitwise method

Referenced commit(s): 1d899cf

… version. (#19997) * fix(CI/MacOS): Fix MacOS CI dependency installation. * Try to use macos 14 version * Remove brew cleanup and z3 dependency * Adjust readline lib discovery * Update macos supported version in SECURITY.md

…sage (#19926) * fix lance requirement error msg * ;

Referenced commit(s): 188b864

* remove weird blanks * update if * ) ) to )) * missed some ) ) * now switch * .

…ehicle (#19920)

* fix(Core/AllMapScript) Update structure to use CALL_ENABLED_HOOKS * fatal error: no template named 'vector' in namespace 'std' * fix build Co-authored-by: Anton Popovichenko <[email protected]> --------- Co-authored-by: Anton Popovichenko <[email protected]>

)

Init.

Referenced commit(s): 7fd507e

…ns (#20104) * fix Orgrim's Hammer and The Skybreaker marker npcs * change insert to update

Referenced commit(s): bc866b1

…to banish effects (e.g cyclone) (#20060)

…kama (#20076) * init * Update boss_shade_of_akama.cpp * Update boss_shade_of_akama.cpp * Update boss_shade_of_akama.cpp * update factions bench with the faction sniffs Co-Authored-By: Benjamin Jackson <[email protected]> * set spawned creatures in combat again Co-Authored-By: Benjamin Jackson <[email protected]> * wip change faction to defender * Update boss_shade_of_akama.cpp * Update boss_shade_of_akama.cpp * set hostiles in combat * Akama shade reset test (#12) compilation of commits with fixes and debugging * Update boss_shade_of_akama.cpp * Update factions_shade.sql * Update factions_shade.sql * Update factions_shade.sql * Update factions_shade.sql * 5s instead of 5ms * change faction enum names * revert faction change on player death * unused import * Update boss_shade_of_akama.cpp * unsummon all non-defenders * clear summons on all players dead * blank space * make creatures not stop spawning on player wipe * oops --------- Co-authored-by: Benjamin Jackson <[email protected]>

Referenced commit(s): 3636d7f

* vehicle aura stacking Rename flight speed related auras Co-authored-by: Laise <[email protected]> * rename to better match existing flight auras

* fix(DB/Gameobject): add gameobjects to transports * remove comment * assign chairs to correct transport

Referenced commit(s): f48f63d

…an is dead (#20118)

* fix(Creature/Model) Model probability change * Fixes compilation and recommendations * Data extracted 51831 Co-authored-by: Benjamin Jackson <[email protected]> --------- Co-authored-by: Benjamin Jackson <[email protected]>

Referenced commit(s): fa0ed1b

* Create boahn.sql * Update boahn.sql

Referenced commit(s): 7de5f72

…#20120)

Referenced commit(s): de7b1ea

Init.

Knindzagxg and others added 30 commits September 12, 2024 21:43

fix(Battlegrounds/AlteracValley): Adding missing Tower Archers (#18746)

d5263b0

Updating Alterac

fix(Core/PlayerStorage): Equip OH, 2H, Titan's Grip weapon swapping (#…

8d7463c

…19884) titan's grip, unequip with full bags

fix(Core/Creature): Add support for CREATURE_FLAG_EXTRA_NO_PARRY_HAST… (

92ec347

#19927)

fix(Scripts/BlackTemple): Fix variable not being set to true when Ak… (…

8030ef4

…#19947) fix(Scripts/BlackTemple): Fix variable not being set to false when Akama dies

fix(Scripts/BlackTemple): fix blaze and flame bast casting for Flame …

bd40fef

…of Azzinoth (#19967) fix(Scripts/Core): fix blaze and flame bast casting for Flame of Azzinoth

fix(Scripts/BlackTemple): Implement emotes when opening Najentus and … (

8b16f7d

#19946) * fix(Scripts/BlackTemple): Implement emotes when opening Najentus and Den of Mortal Delights * only check if state is done

chore(DB): import pending files

d13b696

Referenced commit(s): 8b16f7d

fix(Scripts/BT): correct illidari council enrage timer (#19975)

04c8e85

* fix(Scripts/BT): correct illidari council enrage timer * wrong conversion from 5ae1473 * redundant

fix(Scripts/Commands): Fix level up achievements not being granted (#…

ee6e74e

…19969)

chore(Core/Achievement): cleanup offline achievement (#19976)

1df989f

chore(DB): import pending files

64c9e4a

Referenced commit(s): e2353a1

fix(Core/Spells): Revert triggered spell logic change. (#19983)

3bb5ec7

Revert "fix(Core/Spells): Resolve a case of triggered spells prolonging comba…" This reverts commit edd7e10.

fix(DB/Command): Add help values for various commands. (#19984)

07c54fe

Init.

chore(DB): import pending files

a35f0c4

Referenced commit(s): 07c54fe

fix(Scripts/BlackTemple): Flames of Azzinoth - Fix the charge logic (#…

5af3d2d

…19968) fix(Scripts/BlackTemple): fix the charge mechanic of Flames of Azzinoth * remove also a old duplicate check in a spell script

refactor(Deps/MySQL): Drop MariaDB and MySQL 5.7/8.1 and add MySQL 8.… (

dbde182

#19451)

fix(Core/Loot) fix bug with loot (#19882)

a196f7f

Try to fix bug with loot

Fix(db/creature) black temple illidari assassin riposte ability missi…

1d899cf

…ng (#19957) * fix(DB/Creature) Black Temple - Illidari Assassin: Riposte ability missing * fix(DB/Creature): Black Temple - Illidari Assassin: Riposte ability missing * Update 2024_09_13_00.sql * bitwise method

chore(DB): import pending files

eda0df7

Referenced commit(s): 1d899cf

fix(apps/installer): fix Debian 12 build with mysql (#20003)

2e17b32

fix(DB/ArgentTournament): Stabled Campaign Warhorse missing error mes…

188b864

…sage (#19926) * fix lance requirement error msg * ;

chore(DB): import pending files

0ba59c0

Referenced commit(s): 188b864

chore(Core/Misc): Some cleanup (#19970)

386aea0

* remove weird blanks * update if * ) ) to )) * missed some ) ) * now switch * .

fix(Core/Object): do not add Object to Transport when summoned by a V…

b364e00

…ehicle (#19920)

FrancescoBorzi and others added 29 commits September 29, 2024 13:10

refactor(src/server/apps|database|shared): remove unused imports (#19505

1ebb53a

)

refactor(src/server/game/Movement): remove unused imports (#20098)

6e2306f

refactor(src/server/game/Battle*): remove unused imports (#20097)

1932fd0

refactor(src/server/game/Entities): remove unused imports (#20096)

784e806

fix(Core/GuardAI): crash when killer is null (#20100)

8047694

fix(DB/Creature): Adjust Flame of Azzinoth model data. (#20115)

7fd507e

Init.

chore(DB): import pending files

d1095a9

Referenced commit(s): 7fd507e

refactor(src/server/game/AI): remove unused imports (#20095)

d8c5639

refactor(src/server/game/Grids): remove unused imports (#20094)

9b17898

refactor(src/server/game/Chat): remove unused imports (#20093)

7d2aebb

refactor(src/server/game/Spells): remove unused imports (#20092)

484e19d

refactor(src/server/game/World): remove unused imports (#20090)

b089966

refactor(src/server/game/Globals): remove unused imports (#20088)

ae30489

fix(DB/Creature): Icecrown Orgrim's Hammer and The Skybreaker map ico…

bc866b1

…ns (#20104) * fix Orgrim's Hammer and The Skybreaker marker npcs * change insert to update

chore(DB): import pending files

003eda6

Referenced commit(s): bc866b1

fix(Core/Spells): Restricted aura application prevention when immune …

ee870ff

…to banish effects (e.g cyclone) (#20060)

chore(DB): import pending files

a774bbd

Referenced commit(s): 3636d7f

fix(Core/Unit): Flight Form riding crop, vehicle speed auras (#20079)

9a1f271

* vehicle aura stacking Rename flight speed related auras Co-authored-by: Laise <[email protected]> * rename to better match existing flight auras

fix(DB/Gameobject): add gameobjects to transports (#20117)

f48f63d

* fix(DB/Gameobject): add gameobjects to transports * remove comment * assign chairs to correct transport

chore(DB): import pending files

529e914

Referenced commit(s): f48f63d

fix(Scripts/TheBlackTemple): remove gossip option on Akama when Illid…

82797a4

…an is dead (#20118)

fix(Creature/Model): Model probability change (#20062)

fa0ed1b

* fix(Creature/Model) Model probability change * Fixes compilation and recommendations * Data extracted 51831 Co-authored-by: Benjamin Jackson <[email protected]> --------- Co-authored-by: Benjamin Jackson <[email protected]>

chore(DB): import pending files

a16ac71

Referenced commit(s): fa0ed1b

fix(DB/WailingCaverns): make Boahn cast snake form (#20119)

7de5f72

* Create boahn.sql * Update boahn.sql

chore(DB): import pending files

c8b814d

Referenced commit(s): 7de5f72

fix(DB/Creature): Adjust move type of various Black Temple creatures. (…

de7b1ea

…#20120)

chore(DB): import pending files

67c746b

Referenced commit(s): de7b1ea

fix(Scripts/BlackTemple): Reset Illidan threat with phase four. (#20125)

cc37941

Init.

tarawow merged commit 3c81290 into tarawow:tarawow-master Oct 4, 2024
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update merge master #18

update merge master #18

tarawow commented Oct 4, 2024

update merge master #18

update merge master #18

Conversation

tarawow commented Oct 4, 2024

Changes Proposed:

Issues Addressed:

SOURCE:

Tests Performed:

How to Test the Changes:

Known Issues and TODO List:

How to Test AzerothCore PRs