update merge master

.github/SECURITY.md

@@ -15,23 +15,16 @@ Versions of AzerothCore:
 | AzerothCore Branch | Supported          |
 | ------------------ | ------------------ |
 | master             | :white_check_mark: |
+| Any playerbot fork | :red_circle:       |
+| Any NPCBot fork    | :red_circle:       |
 
 Versions of MySQL:
 
 | MySQL Version | Supported          |
 | ------------- | ------------------ |
-| 8.1           | :white_check_mark: |
+| 8.4           | :white_check_mark: |
 | 8.0           | :white_check_mark: |
-| 5.7           | :white_check_mark: |
-| 5.6 and lower | :red_circle:       |
-
-Versions of MariaDB:
-
-| MariaDB Version | Supported          |
-| --------------- | ------------------ |
-| 10.6            | :white_check_mark: |
-| 10.5            | :white_check_mark: |
-| 10.4 and lower  | :red_circle:       |
+| 5.7 and lower | :red_circle:       |
 
 Versions of CLang:
 
@@ -43,26 +36,26 @@ Versions of CLang:
 
 Versions of GCC:
 
-| GCC Version | Supported          |
-| ----------- | ------------------ |
-| 14          | :white_check_mark: |
-| 12          | :white_check_mark: |
-| 11 and lower| :red_circle:       |
+| GCC Version  | Supported          |
+| ------------ | ------------------ |
+| 14           | :white_check_mark: |
+| 12           | :white_check_mark: |
+| 11 and lower | :red_circle:       |
 
 Versions of Ubuntu:
 
-| Ubuntu version | Supported          |
-| -------------- | ------------------ |
-| 24.04          | :white_check_mark: |
-| 22.04          | :white_check_mark: |
-| 20.04 and lower| :red_circle:       |
+| Ubuntu version  | Supported          |
+| --------------- | ------------------ |
+| 24.04           | :white_check_mark: |
+| 22.04           | :white_check_mark: |
+| 20.04 and lower | :red_circle:       |
 
 Versions of macOS:
 
-| macOS Version  | Supported          |
-| -------------- | ------------------ |
-| 12             | :white_check_mark: |
-| 11 and lower   | :red_circle:       |
+| macOS Version | Supported          |
+| ------------- | ------------------ |
+| 14            | :white_check_mark: |
+| 12 and lower  | :red_circle:       |
 
 **Note**: We do NOT support any repacks that may or may not have been made based on AzerothCore. This is because they are usually based on older versions and there is no way to know what is in the precompiled binaries. Instead, you should compile your binaries from the AzerothCore source. To get started, read the [Installation Guide](https://www.azerothcore.org/wiki/installation).
 

.github/workflows/macos_build.yml

@@ -16,7 +16,7 @@ jobs:
       fail-fast: false
       matrix:
         os:
-          - macos-12
+          - macos-14
     runs-on: ${{ matrix.os }}
     name: ${{ matrix.os }}
     if: |

apps/ci/mac/ci-compile.sh

@@ -28,8 +28,8 @@ time cmake ../../../ \
 -DCMAKE_BUILD_TYPE=Release \
 -DMYSQL_ADD_INCLUDE_PATH=$mysql_include_path \
 -DMYSQL_LIBRARY=$mysql_lib_path \
--DREADLINE_INCLUDE_DIR=/usr/local/opt/readline/include \
--DREADLINE_LIBRARY=/usr/local/opt/readline/lib/libreadline.dylib \
+-DREADLINE_INCLUDE_DIR=$(brew --prefix readline)/include \
+-DREADLINE_LIBRARY=$(brew --prefix readline)/lib/libreadline.dylib \
 -DOPENSSL_INCLUDE_DIR="$OPENSSL_ROOT_DIR/include" \
 -DOPENSSL_SSL_LIBRARIES="$OPENSSL_ROOT_DIR/lib/libssl.dylib" \
 -DOPENSSL_CRYPTO_LIBRARIES="$OPENSSL_ROOT_DIR/lib/libcrypto.dylib" \

apps/codestyle/codestyle.py

@@ -31,7 +31,8 @@ def parsing_file(directory: str) -> None:
                         multiple_blank_lines_check(file, file_path)
                         trailing_whitespace_check(file, file_path)
                         get_counter_check(file, file_path)
-                        misc_codestyle_check(file, file_path)
+                        if not file_name.endswith('.cmake') and file_name != 'CMakeLists.txt':
+                            misc_codestyle_check(file, file_path)
                         if file_name != 'Object.h':
                             get_typeid_check(file, file_path)
                         if file_name != 'Unit.h':
@@ -223,6 +224,10 @@ def misc_codestyle_check(file: io, file_path: str) -> None:
             print(
                 f"Please use the syntax 'Class/ObjectType const*' instead of 'const Class/ObjectType*': {file_path} at line {line_number}")
             check_failed = True
+        if [match for match in [' if(', ' if ( '] if match in line]:
+            print(
+                f"AC have as standard: if (XXXX). Please check spaces in your condition': {file_path} at line {line_number}")
+            check_failed = True
     # Handle the script error and update the result output
     if check_failed:
         error_handler = True

apps/installer/includes/os_configs/debian.sh

@@ -19,11 +19,11 @@ sudo apt-get update -y
 sudo apt-get install -y gdbserver gdb unzip curl \
                      libncurses-dev libreadline-dev clang g++ \
                      gcc git cmake make ccache \
-                     default-libmysqlclient-dev libssl-dev libbz2-dev \
+                     libssl-dev libbz2-dev \
                      libboost-all-dev gnupg wget
 
 # run noninteractive install for MYSQL 8.4 LTS
 wget https://dev.mysql.com/get/mysql-apt-config_0.8.32-1_all.deb
 sudo DEBIAN_FRONTEND="noninteractive" dpkg -i ./mysql-apt-config_0.8.32-1_all.deb
 sudo apt-get update
-sudo DEBIAN_FRONTEND="noninteractive" apt-get install -y mysql-server
+sudo DEBIAN_FRONTEND="noninteractive" apt-get install -y mysql-server libmysqlclient-dev

data/sql/create/drop_mysql.sql

@@ -1,16 +1,4 @@
-REVOKE ALL PRIVILEGES ON * . * FROM 'acore'@'localhost';
-
-REVOKE ALL PRIVILEGES ON `acore_world` . * FROM 'acore'@'localhost';
-
-REVOKE GRANT OPTION ON `acore_world` . * FROM 'acore'@'localhost';
-
-REVOKE ALL PRIVILEGES ON `acore_characters` . * FROM 'acore'@'localhost';
-
-REVOKE GRANT OPTION ON `acore_characters` . * FROM 'acore'@'localhost';
-
-REVOKE ALL PRIVILEGES ON `acore_auth` . * FROM 'acore'@'localhost';
-
-REVOKE GRANT OPTION ON `acore_auth` . * FROM 'acore'@'localhost';
+REVOKE ALL PRIVILEGES, GRANT OPTION FROM 'acore'@'localhost';
 
 DROP USER 'acore'@'localhost';
 

data/sql/updates/db_characters/2024_09_03_00.sql

@@ -1,11 +1,15 @@
 -- DB update 2024_07_05_00 -> 2024_09_03_00
 DROP TABLE IF EXISTS `character_achievement_offline_updates`;
 CREATE TABLE `character_achievement_offline_updates` (
-    `guid` BIGINT UNSIGNED NOT NULL COMMENT 'Character\'s GUID',
+    `guid` INT UNSIGNED NOT NULL COMMENT 'Character\'s GUID',
     `update_type` TINYINT UNSIGNED NOT NULL COMMENT 'Supported types: 1 - COMPLETE_ACHIEVEMENT; 2 - UPDATE_CRITERIA',
     `arg1` INT UNSIGNED NOT NULL COMMENT 'For type 1: achievement ID; for type 2: ACHIEVEMENT_CRITERIA_TYPE',
     `arg2` INT UNSIGNED DEFAULT NULL COMMENT 'For type 2: miscValue1 for updating achievement criteria',
     `arg3` INT UNSIGNED DEFAULT NULL COMMENT 'For type 2: miscValue2 for updating achievement criteria',
     INDEX `idx_guid` (`guid`)
 )
-COMMENT = 'Stores updates to character achievements when the character was offline';
+COMMENT = 'Stores updates to character achievements when the character was offline'
+CHARSET = utf8mb4
+COLLATE = utf8mb4_unicode_ci
+ENGINE = InnoDB
+;

data/sql/updates/db_characters/2024_09_22_00.sql

@@ -0,0 +1,4 @@
+-- DB update 2024_09_03_00 -> 2024_09_22_00
+--
+ALTER TABLE `recovery_item`
+    ADD COLUMN `DeleteDate` INT UNSIGNED NULL DEFAULT NULL AFTER `Count`;

data/sql/updates/db_world/2024_09_15_00.sql

@@ -0,0 +1,3 @@
+-- DB update 2024_09_11_01 -> 2024_09_15_00
+--
+UPDATE `creature_text` SET `TextRange` = 3 WHERE `CreatureId` = 22984;

data/sql/updates/db_world/2024_09_15_01.sql

@@ -0,0 +1,8 @@
+-- DB update 2024_09_15_00 -> 2024_09_15_01
+-- implement QUEST_SPECIAL_FLAGS_NO_LOREMASTER_COUNT
+-- extend column datatype from tinyint to int
+ALTER TABLE `quest_template_addon` MODIFY COLUMN `SpecialFlags` INT UNSIGNED DEFAULT 0 NOT NULL;
+
+-- add flag to Corrupted Flower Quests in Felwood
+UPDATE `quest_template_addon` SET `SpecialFlags` = (`SpecialFlags` | 256)
+WHERE (`ID` IN (996, 998, 1514, 2523, 2878, 3363, 4113, 4114, 4115, 4116, 4117, 4118, 4119, 4221, 4222, 4343, 4401, 4403, 4443, 4444, 4445, 4446, 4447, 4448, 4461, 4462, 4464, 4465, 4466, 4467));

data/sql/updates/db_world/2024_09_16_00.sql

@@ -0,0 +1,172 @@
+-- DB update 2024_09_15_01 -> 2024_09_16_00
+-- wp modify
+
+UPDATE `command` SET `help` = 'Syntax: .gobject set $subcommand
+Type .gobject set to see the list of possible subcommands or .help gobject set $subcommand to see info on subcommands.' WHERE `name` = 'gobject set';
+
+UPDATE `command` SET `help` = 'Syntax: .skirmish [arena] [XvX] [Nick1] [Nick2] ... [NickN]
+[arena] can be \"all\" or comma-separated list of possible arenas (NA, BE, RL, DS, RV).
+[XvX] can be 1v1, 2v2, 3v3, 5v5. After [XvX] specify enough nicknames for that mode.' WHERE `name` = 'skirmish';
+
+UPDATE `command` SET `help` = 'Syntax: .bf $subcommand
+Type .bf to see the list of possible subcommands or .help bf $subcommand to see info on subcommands.' WHERE `name` = 'bf';
+
+UPDATE `command` SET `help` = 'Syntax: .debug entervehicle #entry #seatID
+Enter the targeted or given vehicle ID in the given seat.' WHERE `name` = 'debug entervehicle';
+
+UPDATE `command` SET `help` = 'Syntax: .debug getitemstate #itemState [unchanged/changed/new/removed/queue/check_all]
+Returns all items in a given player''s inventory with a given item state.' WHERE `name` = 'debug getitemstate';
+
+UPDATE `command` SET `help` = 'Syntax: .debug getitemvalue #GUID #index
+Returns the value of the given index for the given item GUID.' WHERE `name` = 'debug getitemvalue';
+
+UPDATE `command` SET `help` = 'Syntax: .debug getvalue #index #isInt
+Returns either an integer or float value at a given index of your target.' WHERE `name` = 'debug getvalue';
+
+UPDATE `command` SET `help` = 'Syntax: .debug hostile
+Returns the hostile reference list of a given player.' WHERE `name` = 'debug hostile';
+
+UPDATE `command` SET `help` = 'Syntax: .debug itemexpire #GUID
+Destroy an item with the given GUID.' WHERE `name` = 'debug itemexpire';
+
+UPDATE `command` SET `help` = 'Syntax: .debug lootrecipient
+Returns the loot recipient of the targeted creature.' WHERE `name` = 'debug lootrecipient';
+
+UPDATE `command` SET `help` = 'Syntax: .debug los
+Returns line of sight status between you and your target.' WHERE `name` = 'debug los';
+
+UPDATE `command` SET `help` = 'Syntax: .debug play $subcommand
+Type .debug play to see the list of possible subcommands or .help debug play $subcommand to see info on subcommands.' WHERE `name` = 'debug play';
+
+UPDATE `command` SET `help` = 'Syntax: .debug send $subcommand
+Type .debug send to see the list of possible subcommands or .help debug send $subcommand to see info on subcommands.' WHERE `name` = 'debug send';
+
+UPDATE `command` SET `help` = 'Syntax: .debug send buyerror #error
+Sends the given buy error result.' WHERE `name` = 'debug send buyerror';
+
+UPDATE `command` SET `help` = 'Syntax: .debug send channelnotify #type
+Sends a channel notify message of the given type.' WHERE `name` = 'debug send channelnotify';
+
+UPDATE `command` SET `help` = 'Syntax: .debug send chatmessage #type
+Sends a chat message of the given type.', `name` = 'debug send chatmessage' WHERE `name` = 'debug send chatmmessage';
+
+UPDATE `command` SET `help` = 'Syntax: .debug send equiperror #error
+Sends the given equip error result.' WHERE `name` = 'debug send equiperror';
+
+UPDATE `command` SET `help` = 'Syntax: .debug send largepacket
+Sends a system message of 128 kilobytes.' WHERE `name` = 'debug send largepacket';
+
+UPDATE `command` SET `help` = 'Syntax: .debug send opcode
+Sends opcodes contained in "opcode.txt".' WHERE `name` = 'debug send opcode';
+
+UPDATE `command` SET `help` = 'Syntax: .debug send qinvalidmsg #error
+Sends the given quest error result.' WHERE `name` = 'debug send qinvalidmsg';
+
+UPDATE `command` SET `help` = 'Syntax: .debug send qpartymsg #message
+Sends the given party quest share message.' WHERE `name` = 'debug send qpartymsg';
+
+UPDATE `command` SET `help` = 'Syntax: .debug send sellerror #error
+Sends the given sell error result.' WHERE `name` = 'debug send sellerror';
+
+UPDATE `command` SET `help` = 'Syntax: .debug send setphaseshift #phaseShift
+Sends a phase shift message with the given phase shift value.' WHERE `name` = 'debug send setphaseshift';
+
+UPDATE `command` SET `help` = 'Syntax: .debug send spellfail #result #failArgument1 #failArgument2
+Sends a spell failure message with the given result and argument values.' WHERE `name` = 'debug send spellfail';
+
+UPDATE `command` SET `help` = 'Syntax: .debug setaurastate #state #apply
+Sets the selected units aura state using the given apply value.' WHERE `name` = 'debug setaurastate';
+
+UPDATE `command` SET `help` = 'Syntax: .debug setbit #index #bit
+Sets the unsigned 32-bit integer value of the target at the given index to the given bit.' WHERE `name` = 'debug setbit';
+
+UPDATE `command` SET `help` = 'Syntax: .debug setitemvalue #GUID #index #value
+Sets the value of the given index for the given item GUID to the given value.' WHERE `name` = 'debug setitemvalue';
+
+UPDATE `command` SET `help` = 'Syntax: .debug setvalue #index #value
+Sets the unsigned 32-bit integer or float value of the target at the given index to the given value.' WHERE `name` = 'debug setvalue';
+
+UPDATE `command` SET `help` = 'Syntax: .debug setvid #ID
+Currently disabled.
+Sets the given target''s vehicle ID to the given value.' WHERE `name` = 'debug setvid';
+
+UPDATE `command` SET `help` = 'Syntax: .debug spawnvehicle #entry #ID
+Creates a vehicle with the given ID.' WHERE `name` = 'debug spawnvehicle';
+
+UPDATE `command` SET `help` = 'Syntax: .debug threat
+Returns the threat list of a given creature.' WHERE `name` = 'debug threat';
+
+UPDATE `command` SET `help` = 'Syntax: .debug update #index #value
+Sets the unsigned 32-bit integer value of the target at the given index to the given bit.' WHERE `name` = 'debug update';
+
+UPDATE `command` SET `help` = 'Syntax: .debug uws #variable #value
+Sends a worldstate update for the given variable to the given value.' WHERE `name` = 'debug uws';
+
+UPDATE `command` SET `help` = 'Syntax: .gobject set state #GUIDLow, #objectType, #objectState
+Sets the byte value or sends a custom animation for a given gameobject GUID.' WHERE `name` = 'gobject set state';
+
+UPDATE `command` SET `help` = 'Syntax: .learn all $subcommand
+Type .learn all to see the list of possible subcommands or .help learn all $subcommand to see info on subcommands.' WHERE `name` = 'learn all';
+
+UPDATE `command` SET `help` = 'Syntax: .learn all my $subcommand
+Type .learn all my to see the list of possible subcommands or .help learn all my $subcommand to see info on subcommands.' WHERE `name` = 'learn all my';
+
+UPDATE `command` SET `help` = 'Syntax: .lfg $subcommand
+Type .lfg to see the list of possible subcommands or .help lfg $subcommand to see info on subcommands.' WHERE `name` = 'lfg';
+
+UPDATE `command` SET `help` = 'Syntax: .lookup player $subcommand
+Type .lookup player to see the list of possible subcommands or .help lookup player $subcommand to see info on subcommands.' WHERE `name` = 'lookup player';
+
+UPDATE `command` SET `help` = 'Syntax: .npc near #distance
+Returns all database creature spawns in a given distance.' WHERE `name` = 'npc near';
+
+UPDATE `command` SET `help` = 'Syntax: .npc set $subcommand
+Type .npc set to see the list of possible subcommands or .help npc set $subcommand to see info on subcommands.' WHERE `name` = 'npc set';
+
+UPDATE `command` SET `help` = 'Syntax: .npc tame
+Creates a player pet of the targeted creature.' WHERE `name` = 'npc tame';
+
+UPDATE `command` SET `help` = 'Syntax: .reload npc_spellclick_spells
+Reload npc_spellclick_spells table.' WHERE `name` = 'reload npc_spellclick_spells';
+
+UPDATE `command` SET `help` = 'Syntax: .spect $subcommand
+Type .spect to see the list of possible subcommands or .help spect $subcommand to see info on subcommands.' WHERE `name` = 'spect';
+
+UPDATE `command` SET `help` = 'Syntax: .spect leave
+Leave an arena you are spectating.' WHERE `name` = 'spect leave';
+
+UPDATE `command` SET `help` = 'Syntax: .spect reset
+Reset various values related to spectating.' WHERE `name` = 'spect reset';
+
+UPDATE `command` SET `help` = 'Syntax: .spect spectate #name
+Begin spectating the given player.' WHERE `name` = 'spect spectate';
+
+UPDATE `command` SET `help` = 'Syntax: .spect version #version
+Verify addon version for arena spectating.' WHERE `name` = 'spect version';
+
+UPDATE `command` SET `help` = 'Syntax: .spect watch #name
+Begin watching the given player.' WHERE `name` = 'spect watch';
+
+UPDATE `command` SET `help` = 'Syntax: .ticket complete #ticketID
+Mark a ticket of the given ID as complete.' WHERE `name` = 'ticket complete';
+
+UPDATE `command` SET `help` = 'Syntax: .ticket escalate #ticketID
+Add a ticket of the given ID to the escalation queue.' WHERE `name` = 'ticket escalate';
+
+UPDATE `command` SET `help` = 'Syntax: .ticket escalatedlist
+Return all open tickets in the escalation queue.' WHERE `name` = 'ticket escalatedlist';
+
+UPDATE `command` SET `help` = 'Syntax: .ticket response $subcommand
+Type .ticket response to see the list of possible subcommands or .help ticket response $subcommand to see info on subcommands.' WHERE `name` = 'ticket response';
+
+UPDATE `command` SET `help` = 'Syntax: .ticket togglesystem
+Toggle whether tickets are allowed or disallowed.' WHERE `name` = 'ticket togglesystem';
+
+UPDATE `command` SET `help` = 'Syntax: .titles $subcommand
+Type .titles to see the list of possible subcommands or .help titles $subcommand to see info on subcommands.' WHERE `name` = 'titles';
+
+UPDATE `command` SET `help` = 'Syntax: .titles set $subcommand
+Type .titles set to see the list of possible subcommands or .help titles set $subcommand to see info on subcommands.' WHERE `name` = 'titles set';
+
+UPDATE `command` SET `help` = 'Syntax: .unban playeraccount #name
+Unban accounts for character name pattern.' WHERE `name` = 'unban playeraccount';

data/sql/updates/db_world/2024_09_20_00.sql

@@ -0,0 +1,6 @@
+-- DB update 2024_09_16_00 -> 2024_09_20_00
+UPDATE `creature_template` SET `flags_extra` = `flags_extra` | 134217728 WHERE `entry` = 23403;
+
+DELETE FROM `smart_scripts` WHERE (`entryorguid` = 23403) AND (`source_type` = 0) AND (`id` IN (2));
+INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `event_param6`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES
+(23403, 0, 2, 0, 0, 0, 100, 0, 0, 15000, 30000, 40000, 0, 0, 11, 41392, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 'Illidari Assassin - In Combat - Cast Riposte');

data/sql/updates/db_world/2024_09_21_00.sql

@@ -0,0 +1,5 @@
+-- DB update 2024_09_20_00 -> 2024_09_21_00
+--
+DELETE FROM `conditions` WHERE `SourceTypeorReferenceiD` = 18 and `SourceGroup` = 34125 AND `ConditionValue1` = 62853;
+DELETE FROM `spell_script_names` WHERE `spell_id`=63215 AND `ScriptName`='spell_gen_summon_tournament_mount';
+INSERT INTO `spell_script_names` (`spell_id`, `ScriptName`) VALUES (63215, 'spell_gen_summon_tournament_mount');

data/sql/updates/db_world/2024_09_21_01.sql

@@ -0,0 +1,3 @@
+-- DB update 2024_09_21_00 -> 2024_09_21_01
+DELETE FROM `command` WHERE `name` = 'debug cooldown';
+INSERT INTO `command` (`name`, `security`, `help`) VALUES ('debug cooldown', 3, 'Syntax: .debug cooldown #spellID #cooldownTime #itemID\nApply a cooldown of the given duration (in milliseconds) for the given spell and item ID.');

data/sql/updates/db_world/2024_09_21_02.sql

@@ -0,0 +1,2 @@
+-- DB update 2024_09_21_01 -> 2024_09_21_02
+UPDATE `creature` SET `equipment_id` = 1 WHERE `id1` = 37967;

data/sql/updates/db_world/2024_09_22_00.sql

@@ -0,0 +1,4 @@
+-- DB update 2024_09_21_02 -> 2024_09_22_00
+--
+UPDATE `quest_offer_reward` SET `RewardText`='We will leave this place on our own, $G Lord:Lady; $N - once we are certain that the evil within has been wholly destroyed. Your journey of legend is almost at an end.', `VerifiedBuild`=0 WHERE `ID`=8801;
+UPDATE `quest_request_items` SET `CompletionText`='$G Lord:Lady; $N, you have freed us of its grasp.', `VerifiedBuild`=0 WHERE `ID`=8801;