Fix format and leaks #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghbaccount
force-pushed
the
fix_format_and_leaks
branch
from
0f52d3c
to
54bdf13
Compare
Reviewed-by: Nickle Wang <[email protected]> Signed-off-by: Mike Maslenkin <[email protected]>
Reviewed-by: Nickle Wang <[email protected]> Signed-off-by: Mike Maslenkin <[email protected]>
Memory allocated by calloc() is filled with bytes of value zero. Reviewed-by: Nickle Wang <[email protected]> Signed-off-by: Mike Maslenkin <[email protected]>
Reviewed-by: Nickle Wang <[email protected]> Signed-off-by: Mike Maslenkin <[email protected]>
This functions contain memory leaks. Less identation helps to solve this issues. Reviewed-by: Nickle Wang <[email protected]> Signed-off-by: Mike Maslenkin <[email protected]>
Reviewed-by: Nickle Wang <[email protected]> Signed-off-by: Mike Maslenkin <[email protected]>
This patch fixes leak in RedfishExternalResourceResourceFeatureCallback function. Reviewed-by: Nickle Wang <[email protected]> Signed-off-by: Mike Maslenkin <[email protected]>
Reviewed-by: Nickle Wang <[email protected]> Signed-off-by: Mike Maslenkin <[email protected]>
StrnCpyS accepts string length in characters, not in bytes. Reviewed-by: Abner Chang <[email protected]> Reviewed-by: Nickle Wang <[email protected]> Signed-off-by: Mike Maslenkin <[email protected]>
Reviewed-by: Nickle Wang <[email protected]> Signed-off-by: Mike Maslenkin <[email protected]>
Reviewed-by: Abner Chang <[email protected]> Reviewed-by: Nickle Wang <[email protected]> Signed-off-by: Mike Maslenkin <[email protected]>
ghbaccount
force-pushed
the
fix_format_and_leaks
branch
from
19b2266
to
a905d84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.