Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix format and leaks #52

Merged
merged 11 commits into from
Oct 31, 2023
Merged

Fix format and leaks #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
50383be
RedfishClientPkg: fix format used for output __func__
ghbaccount Sep 12, 2023
0a012cc
RedfishClientPkg: fix DEBUG macro arguments
ghbaccount Sep 27, 2023
20270a2
RedfishLib: remove redudant zeroing
ghbaccount Sep 27, 2023
7aaf972
RedfishClientPkg: RedfishFeatureUtilityLib: fix memory leaks
ghbaccount Sep 12, 2023
b698b4a
RedfishClientPkg: reduce identation level by adding early return
ghbaccount Sep 28, 2023
c99cf54
RedfishClientPkg: fix memory leaks while applying feature settings
ghbaccount Sep 28, 2023
26026f4
RedfishClientPkg: fix memory leak
ghbaccount Sep 28, 2023
fcfbe0f
RedfishClientPkg: fix pragma pack usage
ghbaccount Sep 27, 2023
38ed05b
RedfishClientPkg: fix StrnCpyS arguments
ghbaccount Sep 27, 2023
2172bf9
RedfishFeatureCoreDxe: replace __FUNCTION__ with __func__
ghbaccount Oct 26, 2023
a905d84
RedfishFeatureCoreDxe: add check for memory allocation failure
ghbaccount Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,7 @@ HandleResource (
// Check and see if this is target resource that we want to handle.
// Some resource is handled by other provider so we have to make sure this first.
//
DEBUG ((REDFISH_DEBUG_TRACE, "%s Identify for %s\n", __func__, Uri));
DEBUG ((REDFISH_DEBUG_TRACE, "%a Identify for %s\n", __func__, Uri));
ConfigLang = RedfishGetConfigLanguage (Uri);
if (ConfigLang == NULL) {
Status = EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, Private->InformationExchange);
Expand Down
2 changes: 2 additions & 0 deletions RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,7 @@ RedfishExternalResourceResourceFeatureCallback (
Private->Uri = RedfishGetUri (ResourceUri);
if (Private->Uri == NULL) {
ASSERT (FALSE);
FreePool (ResourceUri);
return EFI_OUT_OF_RESOURCES;
}

Expand All @@ -727,6 +728,7 @@ RedfishExternalResourceResourceFeatureCallback (
}

FreePool (Private->Uri);
FreePool (ResourceUri);
return Status;
}

Expand Down
3 changes: 2 additions & 1 deletion RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ extern EFI_GUID gHiiToRedfishBiosFormsetGuid;
#define ID_STRING_MAX 15
#define ID_STRING_MAX_WITH_TERMINATOR 16

#pragma pack()
#pragma pack(1)

//
// Definiton of HII_TO_REDFISH_BIOS_VARSTORE_DATA
Expand All @@ -44,4 +44,5 @@ typedef struct {
UINT8 Reserved;
} HII_TO_REDFISH_BIOS_EFI_VARSTORE_DATA;

#pragma pack()
#endif
Loading