Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix format and leaks #52

Merged
merged 11 commits into from
Oct 31, 2023
Merged

Fix format and leaks #52

merged 11 commits into from
Oct 31, 2023

Commits on Oct 30, 2023

  1. RedfishClientPkg: fix format used for output __func__ 

    Reviewed-by: Nickle Wang <[email protected]>
Signed-off-by: Mike Maslenkin <[email protected]>
    @ghbaccount
    ghbaccount committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    50383be View commit details
    Browse the repository at this point in the history

  2. RedfishClientPkg: fix DEBUG macro arguments 

    Reviewed-by: Nickle Wang <[email protected]>
Signed-off-by: Mike Maslenkin <[email protected]>
    @ghbaccount
    ghbaccount committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    0a012cc View commit details
    Browse the repository at this point in the history

  3. RedfishLib: remove redudant zeroing 

    Memory allocated by calloc() is filled with bytes of value zero.

Reviewed-by: Nickle Wang <[email protected]>
Signed-off-by: Mike Maslenkin <[email protected]>
    @ghbaccount
    ghbaccount committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    20270a2 View commit details
    Browse the repository at this point in the history

  4. RedfishClientPkg: RedfishFeatureUtilityLib: fix memory leaks 

    Reviewed-by: Nickle Wang <[email protected]>
Signed-off-by: Mike Maslenkin <[email protected]>
    @ghbaccount
    ghbaccount committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    7aaf972 View commit details
    Browse the repository at this point in the history

  5. RedfishClientPkg: reduce identation level by adding early return 

    This functions contain memory leaks.
Less identation helps to solve this issues.

Reviewed-by: Nickle Wang <[email protected]>
Signed-off-by: Mike Maslenkin <[email protected]>
    @ghbaccount
    ghbaccount committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    b698b4a View commit details
    Browse the repository at this point in the history

  6. RedfishClientPkg: fix memory leaks while applying feature settings 

    Reviewed-by: Nickle Wang <[email protected]>
Signed-off-by: Mike Maslenkin <[email protected]>
    @ghbaccount
    ghbaccount committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    c99cf54 View commit details
    Browse the repository at this point in the history

  7. RedfishClientPkg: fix memory leak 

    This patch fixes leak in RedfishExternalResourceResourceFeatureCallback
function.

Reviewed-by: Nickle Wang <[email protected]>
Signed-off-by: Mike Maslenkin <[email protected]>
    @ghbaccount
    ghbaccount committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    26026f4 View commit details
    Browse the repository at this point in the history

  8. RedfishClientPkg: fix pragma pack usage 

    Reviewed-by: Nickle Wang <[email protected]>
Signed-off-by: Mike Maslenkin <[email protected]>
    @ghbaccount
    ghbaccount committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    fcfbe0f View commit details
    Browse the repository at this point in the history

  9. RedfishClientPkg: fix StrnCpyS arguments 

    StrnCpyS accepts string length in characters, not in bytes.

Reviewed-by: Abner Chang <[email protected]>
Reviewed-by: Nickle Wang <[email protected]>
Signed-off-by: Mike Maslenkin <[email protected]>
    @ghbaccount
    ghbaccount committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    38ed05b View commit details
    Browse the repository at this point in the history

  10. RedfishFeatureCoreDxe: replace __FUNCTION__ with __func__ 

    Reviewed-by: Nickle Wang <[email protected]>
Signed-off-by: Mike Maslenkin <[email protected]>
    @ghbaccount
    ghbaccount committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    2172bf9 View commit details
    Browse the repository at this point in the history

  11. RedfishFeatureCoreDxe: add check for memory allocation failure 

    Reviewed-by: Abner Chang <[email protected]>
Reviewed-by: Nickle Wang <[email protected]>
Signed-off-by: Mike Maslenkin <[email protected]>
    @ghbaccount
    ghbaccount committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    a905d84 View commit details
    Browse the repository at this point in the history