-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add auto information #112
Conversation
Codecov Report
@@ Coverage Diff @@
## main #112 +/- ##
==========================================
- Coverage 90.93% 89.73% -1.21%
==========================================
Files 30 33 +3
Lines 2615 2923 +308
Branches 501 562 +61
==========================================
+ Hits 2378 2623 +245
- Misses 136 179 +43
- Partials 101 121 +20
|
Finish implementation skeleton and test against original lib
Here, I reuse the parameter @mscheltienne do you think it's a big problem to change the variable name (for backwards compatibility) ? Maybe we could introduce it as an alias for the transition module. |
I took care of the conflicts and removed the deprecation from this PR. |
for more information, see https://pre-commit.ci
…nto dev-aifpaif
* updating 10_entropy notebook * updating 10_entropy notebook * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update tutorial export ipynb to .py Add references * Update 10_entropy.py * Update 10_entropy.py * Update 10_entropy.py * Update 10_entropy.py * Update 10_entropy.py * Update 10_entropy.py * Update 10_entropy.py * Update 10_entropy.py * Update 10_entropy.py * updating 10_entropy notebook * Add authors * Update 10_entropy.py * Update 10_entropy.py * Update 10_entropy.py --------- Co-authored-by: “Frederic-vW” <“[email protected]”> Co-authored-by: Victor Férat <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@mscheltienne ready for review ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, couple style improvements and I've sneak in new make files for the documentation build with additional options and fixed the dead changelog links that we did not notice previously.
Adapt code from https://github.com/Frederic-vW/AIF-PAIF as discussed in this issue and by emails.