Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add auto information #112

Merged
merged 81 commits into from
Feb 13, 2024
Merged

[ENH] Add auto information #112

merged 81 commits into from
Feb 13, 2024

Conversation

vferat
Copy link
Owner

@vferat vferat commented May 26, 2023

Adapt code from https://github.com/Frederic-vW/AIF-PAIF as discussed in this issue and by emails.

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #112 (777f0c5) into main (2562921) will decrease coverage by 1.21%.
Report is 7 commits behind head on main.
The diff coverage is 92.04%.

❗ Current head 777f0c5 differs from pull request most recent head 24b7462. Consider uploading reports for the commit 24b7462 to get more accurate results

@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   90.93%   89.73%   -1.21%     
==========================================
  Files          30       33       +3     
  Lines        2615     2923     +308     
  Branches      501      562      +61     
==========================================
+ Hits         2378     2623     +245     
- Misses        136      179      +43     
- Partials      101      121      +20     
Files Coverage Δ
pycrostates/_typing.py 100.00% <100.00%> (ø)
pycrostates/cluster/aahc.py 97.79% <100.00%> (ø)
pycrostates/cluster/kmeans.py 96.66% <100.00%> (ø)
pycrostates/cluster/utils/utils.py 85.71% <ø> (ø)
pycrostates/datasets/lemon/lemon.py 92.85% <ø> (ø)
pycrostates/io/ch_data.py 91.78% <100.00%> (-2.51%) ⬇️
pycrostates/io/fiff.py 75.57% <100.00%> (-2.24%) ⬇️
pycrostates/io/meas_info.py 81.39% <100.00%> (-3.32%) ⬇️
pycrostates/io/reader.py 100.00% <100.00%> (ø)
pycrostates/metrics/calinski_harabasz.py 100.00% <100.00%> (ø)
... and 18 more

... and 4 files with indirect coverage changes

@vferat vferat changed the title Add autoinformation Add entropy Aug 9, 2023
@vferat
Copy link
Owner Author

vferat commented Aug 10, 2023

Here, I reuse the parameter ignore_self introduced in the #91. I find that the name isn't very explicit, especially outside the context of transition probabilities ( "transition to itself"). I think it would be good to have a generic and explicit name that would indicate when an analysis considers segmentation with state repetition (AABBBC) or without (ABC).

@mscheltienne do you think it's a big problem to change the variable name (for backwards compatibility) ? Maybe we could introduce it as an alias for the transition module.
Also, do you have any suggestion for a more explicit name ? ignore_repeated_states, ignore_repeation?

@mscheltienne
Copy link
Collaborator

I took care of the conflicts and removed the deprecation from this PR.

@vferat vferat mentioned this pull request Jan 31, 2024
* updating 10_entropy notebook

* updating 10_entropy notebook

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update tutorial

export ipynb to .py
Add references

* Update 10_entropy.py

* Update 10_entropy.py

* Update 10_entropy.py

* Update 10_entropy.py

* Update 10_entropy.py

* Update 10_entropy.py

* Update 10_entropy.py

* Update 10_entropy.py

* Update 10_entropy.py

* updating 10_entropy notebook

* Add authors

* Update 10_entropy.py

* Update 10_entropy.py

* Update 10_entropy.py

---------

Co-authored-by: “Frederic-vW” <“[email protected]”>
Co-authored-by: Victor Férat <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@vferat
Copy link
Owner Author

vferat commented Feb 6, 2024

@mscheltienne ready for review !

@mscheltienne mscheltienne marked this pull request as ready for review February 6, 2024 16:25
Copy link
Collaborator

@mscheltienne mscheltienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple style improvements and I've sneak in new make files for the documentation build with additional options and fixed the dead changelog links that we did not notice previously.

@vferat vferat merged commit 146cad9 into main Feb 13, 2024
18 of 19 checks passed
@mscheltienne mscheltienne deleted the dev-aifpaif branch February 13, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants