feat: set the correct external sender key when creating MLS conversation #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamadJaara
commented
May 2, 2024
| override fun fromDTO(publicKeys: MLSPublicKeysDTO) = with(publicKeys) { | ||
| removal?.entries?.mapNotNull { | ||
| when (it.key) { | ||
| ED25519 -> MLSPublicKey(Ed25519Key(it.value.decodeBase64Bytes()), KeyType.REMOVAL) |
There was a problem hiding this comment.
this mapper will always return a list containing one item or null, so it was removed with choosing the correct signature from the map
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
mchenani
reviewed
May 3, 2024
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/mlspublickeys/MLSPublicKeysRepository.kt
Outdated
Show resolved
Hide resolved
mchenani
reviewed
May 3, 2024
logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/client/RegisterMLSClientUseCase.kt
Outdated
Show resolved
Hide resolved
mchenani
approved these changes
May 3, 2024
…ly' into feat/set-the-correct-public-key-when-creating-MLS-conversation # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/client/MLSClientProvider.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt
Signed-off-by: MohamadJaara <[email protected]>
…ly' into feat/set-the-correct-public-key-when-creating-MLS-conversation # Conflicts: # gradle/libs.versions.toml
MohamadJaara
changed the base branch from
release/android-cycle-4.6
to
fix/fetch-MLS-config-when-not-avilable-locally
7 tasks
vitorhugods
approved these changes
May 7, 2024
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/mlspublickeys/MLSPublicKeysMapper.kt
Outdated
Show resolved
Hide resolved
…ickeys/MLSPublicKeysMapper.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]>
Base automatically changed from
fix/fetch-MLS-config-when-not-avilable-locally
to
release/android-cycle-4.6
May 7, 2024 09:04
…le-4.6' into feat/set-the-correct-public-key-when-creating-MLS-conversation # Conflicts: # cryptography/src/commonJvmAndroid/kotlin/com.wire.kalium.cryptography/CoreCryptoCentral.kt
MohamadJaara
deleted the
feat/set-the-correct-public-key-when-creating-MLS-conversation
branch
This was referenced May 7, 2024
This was referenced May 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
when creating a new conversation, we need to set the server public key matching the default cipher suite
Solutions
select the matching signature from cipher suite
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.