-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sim] Add SendableChooserSim #6763
Merged
PeterJohnson
merged 8 commits into
wpilibsuite:main
from
Gold856:sendable-chooser-setter
Aug 15, 2024
Merged
[sim] Add SendableChooserSim #6763
PeterJohnson
merged 8 commits into
wpilibsuite:main
from
Gold856:sendable-chooser-setter
Aug 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gold856
force-pushed
the
sendable-chooser-setter
branch
2 times, most recently
from
June 22, 2024 04:06
9044283
to
d765b8c
Compare
calcmogul
previously requested changes
Jun 22, 2024
wpilibj/src/test/java/edu/wpi/first/wpilibj/smartdashboard/SendableChooserTest.java
Outdated
Show resolved
Hide resolved
Gold856
force-pushed
the
sendable-chooser-setter
branch
from
June 22, 2024 20:51
0a1e462
to
f28b76f
Compare
Gold856
force-pushed
the
sendable-chooser-setter
branch
from
July 19, 2024 04:57
2da20ed
to
6af86a8
Compare
Gold856
force-pushed
the
sendable-chooser-setter
branch
from
August 4, 2024 01:13
6af86a8
to
68da53f
Compare
rzblue
requested changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that looks good!
wpilibj/src/main/java/edu/wpi/first/wpilibj/simulation/SendableChooserSim.java
Outdated
Show resolved
Hide resolved
wpilibc/src/main/native/include/frc/simulation/SendableChooserSim.h
Outdated
Show resolved
Hide resolved
rzblue
previously approved these changes
Aug 9, 2024
Gold856
force-pushed
the
sendable-chooser-setter
branch
from
August 14, 2024 05:07
8f64180
to
72fe84b
Compare
Co-authored-by: Tyler Veness <[email protected]>
Co-authored-by: Joseph Eng <[email protected]>
Gold856
force-pushed
the
sendable-chooser-setter
branch
from
August 15, 2024 02:09
72fe84b
to
2a91240
Compare
PeterJohnson
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #6252, resolves #3731.