Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add and test examples directory #111

Merged
merged 26 commits into from
Sep 12, 2023
Merged

fix: add and test examples directory #111

merged 26 commits into from
Sep 12, 2023

Conversation

eliobischof
Copy link
Member

@eliobischof eliobischof commented Jul 8, 2023 •
edited
Loading

Closes: #91

  • Enables TLS for Postgres
  • Fixes zitadel user TLS for cockroach
  • I had to break the values.yaml for these fixes, therefore set the version to v6.0.0
  • Described the upgrade path in the README.md
  • Added an example folder with yaml files and their own README.md files.
  • Added a subfolder for each existing test and all cases described in Add and test examples for common values #91. I combined TLS and pw auth into secure Postgres and secure Cockroach.
  • Tested each example with these exact files.
  • Linked the examples in the README.md
  • Updated the postgres testing and examples dependency to the latest chart version
  • Simplified the test folder structure
  • Updated KinD and tested node images like described in the release notes. I will change the branch protection rule as soon as the PR is approved.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@eliobischof eliobischof marked this pull request as draft July 28, 2023 11:40
@eliobischof eliobischof mentioned this pull request Jul 28, 2023
Merged
13 tasks
@eliobischof eliobischof self-assigned this Aug 25, 2023
@eliobischof eliobischof marked this pull request as ready for review August 25, 2023 23:01
@eliobischof eliobischof requested a review from stebenz August 25, 2023 23:03
@eliobischof eliobischof changed the title docs: add and test examples directory fix: add and test examples directory Aug 28, 2023
@eliobischof eliobischof requested a review from muhlemmer August 29, 2023 12:18
muhlemmer
muhlemmer reviewed Aug 29, 2023
View reviewed changes
Copy link
Contributor

@muhlemmer muhlemmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed all the Go code and looks good to me.

The charts/zitadel/templates/* and examples/* will need to be checked by someone with k8s knowledge.

charts/zitadel/acceptance/accessibility.go Show resolved Hide resolved
@eliobischof
Copy link
Member Author

I reviewed all the Go code and looks good to me.

The charts/zitadel/templates/* and examples/* will need to be checked by someone with k8s knowledge.

@stebenz can you please review the rest?

This was referenced Aug 29, 2023
Closed
Closed
@eliobischof eliobischof linked an issue Aug 29, 2023 that may be closed by this pull request
Error on .Values.zitadel.configmapConfig.FirstInstance.MachineKeyPath (still in values.yaml) #120
Closed
@eliobischof eliobischof mentioned this pull request Aug 29, 2023
Closed
@eliobischof eliobischof linked an issue Aug 29, 2023 that may be closed by this pull request
Bug: If dbSslRootCrtSecret and/or dbSslClientCrtSecret are defined in default values, they will always be tried to mount #113
Closed
@eliobischof eliobischof mentioned this pull request Aug 29, 2023
Closed
2 tasks
stebenz
stebenz previously approved these changes Sep 8, 2023
View reviewed changes
@eliobischof
Copy link
Member Author

eliobischof commented Sep 12, 2023 •
edited
Loading

@stebenz, @muhlemmer, I specified nice job names with this commit bb6d5e0.

Without this, I wasn't able to use the jobs for the checks in the branch protection, because the image shas were too long, I guess.

The checks pass now, can you reapprove, plz?

@eliobischof
Copy link
Member Author

@stebenz, @muhlemmer, I specified nice job names with this commit bb6d5e0.

Without this, I wasn't able to use the jobs for the checks in the branch protection, because the image shas were too long, I guess.

The checks pass now, can you reapprove, plz?

I'll just merge

@eliobischof eliobischof merged commit 9d2a8c2 into main Sep 12, 2023
@eliobischof eliobischof deleted the test-examples branch September 12, 2023 12:52
kleberbaum pushed a commit to fhkit/zitadel-charts that referenced this pull request May 24, 2024
@eliobischof
fix: add and test examples directory (zitadel#111)
104c92f 
* docs: add and test examples directory

* docs: add postgres examples

* fix 2-postgres-pw-auth

* enable tls auth

* find out db type

* simplify masterkey

* add new-certs.sh

* pg cert

* fix 3-postgres-cert-auth

* make tests pass

* create certs in jobs

* update Chart.yaml

* test with latest postgres chart

* update docs

* describe breaking changes

* cleanup

* fix warning boxes

* fix repo url

* remove potential flakiness

* increase timeout

* update kind and tested node images

* wait with k8s 1.28

* test grpc

* back to localhost

* chore: shorten job names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhlemmer muhlemmer Awaiting requested review from muhlemmer

@stebenz stebenz Awaiting requested review from stebenz

Assignees

@eliobischof eliobischof

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@eliobischof @muhlemmer @stebenz