Add Duck Player prime modal #4824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 31, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CrisBarreiro and the rest of your teammates on |
CrisBarreiro
force-pushed
the
feature/cris/duck-player-bottom-sheet
branch
2 times, most recently
from
92086a5 to
9c50362
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player-bottom-sheet
branch
from
b8170e3 to
3d1bff8
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player-bottom-sheet
branch
2 times, most recently
from
edd7f0e to
9fd2a15
Compare
CrisBarreiro
force-pushed
the
feature/cris/navigate-back-from-duck-player
branch
from
30fced9 to
5172524
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player-bottom-sheet
branch
from
9fd2a15 to
23fc362
Compare
CrisBarreiro
force-pushed
the
feature/cris/navigate-back-from-duck-player
branch
from
5172524 to
8789ab0
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player-bottom-sheet
branch
from
23fc362 to
0b7c89c
Compare
CrisBarreiro
force-pushed
the
feature/cris/navigate-back-from-duck-player
branch
from
8789ab0 to
8c40743
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player-bottom-sheet
branch
from
0b7c89c to
8b9dafd
Compare
CrisBarreiro
force-pushed
the
feature/cris/navigate-back-from-duck-player
branch
from
8c40743 to
1865035
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player-bottom-sheet
branch
from
8b9dafd to
e136a14
Compare
CrisBarreiro
force-pushed
the
feature/cris/navigate-back-from-duck-player
branch
from
1865035 to
742ea02
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player-bottom-sheet
branch
from
e136a14 to
e815f2e
Compare
|
One problem that I'm seeing on my S10 Android 12. When the screen is in landscape the X to close the popup is over/below the bottom bar and the X is unclickable.
|
CrisBarreiro
force-pushed
the
feature/cris/duck-player-bottom-sheet
branch
from
e815f2e to
7f8dc5a
Compare
@marcosholgado can you try again? I've made some changes but don't have any Samsung devices to test on |
CrisBarreiro
force-pushed
the
feature/cris/navigate-back-from-duck-player
branch
from
742ea02 to
ae1e3be
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player-bottom-sheet
branch
from
7f8dc5a to
f6be548
Compare
CrisBarreiro
force-pushed
the
feature/cris/navigate-back-from-duck-player
branch
from
ae1e3be to
54cc443
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player-bottom-sheet
branch
from
f6be548 to
4f59bc3
Compare
marcosholgado
approved these changes
Aug 8, 2024
| @@ -168,6 +169,9 @@ class DuckPlayerJSHelper @Inject constructor( | |||
| "openSettings" -> { | |||
| return OpenDuckPlayerSettings | |||
| } | |||
| "openInfo" -> { | |||
There was a problem hiding this comment.
Tested in next PR, #4872
| @@ -133,6 +133,7 @@ class ContentScopeScriptsJsMessaging @Inject constructor( | |||
| "sendDuckPlayerPixel", | |||
| "setUserValues", | |||
| "openDuckPlayer", | |||
| "openInfo", | |||
There was a problem hiding this comment.
Should we test this type of message too?
There was a problem hiding this comment.
Tested in next PR, #4872
3 tasks
This was referenced Aug 14, 2024
Closed
Merged
CrisBarreiro
force-pushed
the
feature/cris/navigate-back-from-duck-player
branch
from
54cc443 to
0a98f10
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player-bottom-sheet
branch
from
4f59bc3 to
9797a52
Compare
CrisBarreiro
force-pushed
the
feature/cris/navigate-back-from-duck-player
branch
from
0a98f10 to
2d3b27f
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player-bottom-sheet
branch
from
9797a52 to
864511c
Compare
CrisBarreiro
force-pushed
the
feature/cris/navigate-back-from-duck-player
branch
from
2d3b27f to
9539c9c
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player-bottom-sheet
branch
from
864511c to
4930428
Compare
Base automatically changed from
feature/cris/navigate-back-from-duck-player
to
feature/cris/duckplayer/create-module
August 20, 2024 15:40
CrisBarreiro
merged commit 4930428
into
feature/cris/duckplayer/create-module
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1207812780384049/f
Description
Steps to test this PR
Feature 1
UI changes